WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 4 months ago

#23433 new defect (bug)

Custom background select needs a contextualized label

Reported by: xibe Owned by:
Priority: normal Milestone: 3.6
Component: I18N Version: 3.5
Severity: minor Keywords: has-patch ui-focus
Cc:

Description

In /themes.php?page=custom-background, the fixed/scroll selector uses the 'Attachment' label.

Problem is, that label name is also used for another type of attachment: files.

Ergo, translators might find themselves with an incorrect wording. In effect, the French translation displays "Fichier attaché" (attached file) instead of a more appropriate term.

I suggest turning the string into a contextualized one.

Another solution would be to change the wording altogether, for instance: "Behaviour when scrolling", with "Scroll along" and "Keep in place" as its options.

Hence, I submit both (hopefully correct) patches -- built against trunk for now, but the issue obviously exists in 3.5.

Attachments (2)

custom-background-selector-label-context.patch (678 bytes) - added by xibe 4 months ago.
Patch for context, against trunk.
custom-background-selector-label-change.patch (952 bytes) - added by xibe 4 months ago.
Patch for name change, against trunk.

Download all attachments as: .zip

Change History (4)

xibe4 months ago

Patch for context, against trunk.

xibe4 months ago

Patch for name change, against trunk.

comment:1 SergeyBiryukov4 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:2 SergeyBiryukov4 months ago

  • Keywords ui-focus added
Note: See TracTickets for help on using tickets.