Opened 3 months ago

Closed 3 months ago

#23549 closed enhancement (fixed)

Twenty Thirteen: header area with no site title or tagline should still be clickable (link to home)

Reported by: lancewillett Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: mdhansen@…

Description

Header area should probably link to home_url() even if no title or tagline.

Attachments (2)

23549.diff​ (1.1 KB) - added by sabreuse 3 months ago.
23549.2.diff​ (2.9 KB) - added by lancewillett 3 months ago.

Download all attachments as: .zip

Change History (8)

sabreuse — 3 months ago

comment:1   sabreuse — 3 months ago

23549.diff moves the home_url link to include the entire hgroup. Clicky goodness!

comment:2   sabreuse — 3 months ago

  • Keywords has-patch added; needs-patch removed

comment:3   kwight — 3 months ago

That's what I was thinking too – you beat me to it.

Patch works for me.

It's odd though, seeing the :hover underline when mousing over anywhere in the header. Hm.

lancewillett — 3 months ago

comment:4   lancewillett — 3 months ago

One thing that would break with the first patch would be any CSS selectors that expected the anchor around the site title. Things like changing Header Text Color.

2nd patch addresses that as well as the hover style kwight mentioned.

comment:5   MikeHansenMe — 3 months ago

  • Cc mdhansen@… added

Tested patch .2 and it works as expected. Also tested the customizer, it also works as expected.

comment:6   lancewillett — 3 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23492:

Twenty Thirteen: header area with no site title or tagline should still be clickable to home. Fixes #23549.

Fix also removes several !important flags that aren't necessary, relating to header text color.

Note: See TracTickets for help on using tickets.