#23695 closed enhancement (fixed)
Add orientation information to gallery items
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Gallery | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | lancewillett, nacin |
Description
It would be highly beneficial for Twenty Thirteen to have information about image orientation for the way it implements galleries on index (#23649). Adding it in gallery_shortcode() would make it available to all themes, and would make it easier to style images in different orientations differently.
Plugins like Jetpack currently do their own orientation detection, something that could easily become obsolete.
Attachments (1)
Change History (8)
comment:1
lancewillett — 3 months ago
comment:2
lancewillett — 3 months ago
Noting a quick "just looked at it, seems fine" from Nacin in IRC today. We'd like to get this in before freeze so we can finalize Twenty Thirteen's gallery handling and avoid adding custom code to the theme.
comment:3
SergeyBiryukov — 3 months ago
- Keywords commit added
comment:4
SergeyBiryukov — 2 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 23649:
comment:5
SergeyBiryukov — 2 months ago
- Type changed from defect (bug) to enhancement
Should the CSS classes maybe be prefixed with "orientation-" or something similar?
comment:7
in reply to:
↑ 6
SergeyBiryukov — 2 months ago
Replying to TobiasBg:
Should the CSS classes maybe be prefixed with "orientation-" or something similar?
A quick IRC discussion: https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-03-08&sort=asc#m571516
Patch looks good. Assuming we don't need escaping for the class value since the two possible values are hard-coded?