Opened 2 months ago

Closed 6 weeks ago

#23830 closed enhancement (fixed)

Update to Backbone 1.0.0

Reported by: mattwiebe Owned by: nacin
Priority: normal Milestone: 3.6
Component: External Libraries Version: trunk
Severity: normal Keywords:
Cc: adamsilverstein@…

Description

Backbone 1.0.0 was released today.

I've done a cursory test of the media modal and the current state of revisions and everything appears to be working fine.

Attachments (2)

backbone.diff​ (37.2 KB) - added by mattwiebe 2 months ago.
23830.diff​ (38.8 KB) - added by koopersmith 2 months ago.

Download all attachments as: .zip

Change History (12)

mattwiebe — 2 months ago

comment:1   SergeyBiryukov — 2 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:2   SergeyBiryukov — 2 months ago

  • Type changed from defect (bug) to enhancement

comment:3   koopersmith — 2 months ago

  • Keywords needs-patch added; has-patch needs-testing removed

That's not the case — Collections were changed to fire "set" instead of "reset", which is causing a bunch of breakage. The patch doesn't bust the cache, so you were likely still seeing 0.9.10.

koopersmith — 2 months ago

comment:4   koopersmith — 2 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

This should get us most of the way there. I think there still may be a rough edge or two; please test and record what you find.

comment:5   nacin — 7 weeks ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23893:

Backbone 1.0.0.

Update media JS to reflect changes. Please open new tickets for remaining issues.

props koopersmith.
fixes #23830.

comment:6 follow-up: ↓ 10   kovshenin — 7 weeks ago

I tried to debug this, but seems like it's beyond my backbone skills. After the 1.0.0 update in [23893], the Attachments collection has always got one more element than it should, resulting in an weird empty element on all media screens: ​http://cl.ly/image/3x033D2i0H3t

comment:7   kovshenin — 7 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8   ocean90 — 7 weeks ago

  • Keywords needs-patch added; has-patch needs-testing removed

comment:9   adamsilverstein — 7 weeks ago

  • Cc adamsilverstein@… added

comment:10 in reply to: ↑ 6   SergeyBiryukov — 6 weeks ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to kovshenin:

After the 1.0.0 update in [23893], the Attachments collection has always got one more element than it should, resulting in an weird empty element on all media screens: ​http://cl.ly/image/3x033D2i0H3t

Let's handle this in #24094.

Note: See TracTickets for help on using tickets.