WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24269 closed enhancement (fixed)

Twenty Thirteen: Remove twentythirteen_search_form_format()

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Per ticket:23850:19, we can replace twentythirteen_search_form_format() with an add_theme_support() call once the latest patch is committed.

Attachments (2)

24269.patch​ (1.2 KB) - added by SergeyBiryukov 11 years ago.
24269.1.patch​ (1.2 KB) - added by lancewillett 11 years ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov
11 years ago

#1 @lancewillett
11 years ago

  • Milestone changed from Awaiting Review to 3.6

#2 @lancewillett
11 years ago

  • Keywords reporter-feedback added

Any word on when this will need to change?

#3 @SergeyBiryukov
11 years ago

  • Keywords commit added; reporter-feedback removed

[24225]

@lancewillett
11 years ago

#4 @lancewillett
11 years ago

  • Keywords commit removed

Patch refreshed. Still needs core changes, though, see #23850.

#5 @lancewillett
11 years ago

  • Keywords needs-refresh added

Obenland refreshed patch on #23850 today, needs a commit, then we can change Twenty Thirteen add_theme_support to match.

#6 @lancewillett
11 years ago

  • Keywords commit added; needs-refresh removed

Asked for a commit on #23850 today in #wordpress-dev IRC during core dev chat.

#7 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24421:

Twenty Thirteen: Remove twentythirteen_search_form_format() filter in favor of add_theme_support() call for search form, comment form, and comment list markup. Props SergeyBiryukov, fixes #24269; see #23850.

Note: See TracTickets for help on using tickets.