Strict Standards errors on plugin search

[DrewAPicture]

A user in Alpha/Beta ​reported getting Strict Standards errors doing a plugins search in Plugins > Add New. He first tried on Beta4, then again on RC1.

He's running PHP 5.4.7 (​full stack)

The error(s):

"Strict Standards: Only variables should be passed by reference in C:\xampp\htdocs\wpbeta\wp-admin\includes\plugin-install.php on line 232"

His search string:

http://localhost/wpbeta/wp-admin/plugin-install.php?tab=search&s=jonradio&plugin-search-input=Search+Plugins

Unfortunately, I don't have a PHP 5.4 install to try and reproduce it on, so maybe somebody else here can give it a go. I couldn't reproduce it on PHP 5.3.5, not sure what version @mordauk tested on.

[SergeyBiryukov]

Introduced in [9793]. The fix is the same as in [19072] and [19074].

[DrewAPicture]

Replying to SergeyBiryukov:

Introduced in [9793]. The fix is the same as in [19072] and [19074].

Cool. Is this is a PHP version-specific thing -- in other words -- how would one reproduce this?

[adiant]

Further testing indicates that this error message appears whenever the search for plugins includes a plugin that is already installed. All that said, I have not yet been able to reproduce the error on the Linux shared hosting that I use "for Production".

[SergeyBiryukov]

Replying to DrewAPicture:

Cool. Is this is a PHP version-specific thing -- in other words -- how would one reproduce this?

I can reproduce in PHP 5.3 by setting error_reporting( E_ALL | E_STRICT ) in a mu-plugin.

In PHP 5.4, E_ALL includes E_STRICT, so just define('WP_DEBUG', true) in wp-config.php is enough.

As noted in comment:6, the message only appears for already installed plugins that don't have an update yet.

[aaroncampbell]

24747.patch​ looks good to me. Tested and confirmed error before the patch and fixed after.

[westi]

In 24725:

Fix a strict standards error in the plugin search when search for an already installed plugin.

Fixes #24747 props SergeyBiryukov.