WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24778 closed defect (bug) (fixed)

Fatal error in _deprecated_function() called from sunrise.php

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: westi's profile westi
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Multisite Keywords: has-patch commit 2nd-opinion
Focuses: Cc:

Description

Background: #23555.

I accidentally still had sunrise.php file left from that ticket, which calls wpdb::escape().

[24718] causes a fatal error in this situation, since the translation functions are not available yet. [24439] fixed the issue for doing_it_wrong(), but not for _deprecated_*() functions.

Attachments (1)

24778.patch​ (4.0 KB) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov
11 years ago

#1 @SergeyBiryukov
11 years ago

24778.patch​ replicates [24439] for _deprecated_*() functions.

#2 @nacin
11 years ago

  • Keywords commit 2nd-opinion added

Yum. MarkJaquith, this is good.

#3 @aaroncampbell
11 years ago

24778.patch​ looks good to me.

#4 @westi
11 years ago

  • Owner set to westi
  • Resolution set to fixed
  • Status changed from new to closed

In 24723:

Fall back to non-translated strings in _deprecated_*() if the translation function doesn't exist. This may be the case in sunrise, for example.

Fixes #24778 props SergeyBiryukov.

Note: See TracTickets for help on using tickets.