WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#24820 closed defect (bug) (fixed)

Clean up wp_audio_shortcode() and wp_video_shortcode()

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: 3.6 Priority: low
Severity: minor Version: 3.6
Component: Embeds Keywords:
Focuses: Cc:

Description

Some post format remnants in both of these functions.

Also, I think we should pass the content width to the wp-mediaelement.js script and specify it for the audioWidth option (width of the audio player).

Attachments (4)

media-shortcode-cleanup.diff​ (2.3 KB) - added by rfair404 11 years ago.
replaces the format based classes with wp-media and wp-{type} classes
without-localizing.diff​ (1.6 KB) - added by rfair404 11 years ago.
without localization
without-localizing2.diff​ (1.6 KB) - added by rfair404 11 years ago.
24820.diff​ (1.2 KB) - added by rfair404 11 years ago.
exclude the changes to wp-mediaelement.js

Download all attachments as: .zip

Change History (9)

#1 @nacin
11 years ago

Related bug: #24421.

@rfair404
11 years ago

replaces the format based classes with wp-media and wp-{type} classes

#2 @rfair404
11 years ago

Not sure if localizing the width is very useful without "doing something" with the width value, e.g. modifying the mediaelement.js.

@rfair404
11 years ago

without localization

@rfair404
11 years ago

@rfair404
11 years ago

exclude the changes to wp-mediaelement.js

#3 @rfair404
11 years ago

  • Cc rfair404 added
  • Component changed from General to Embeds

#4 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24857:

Update HTML classes in the audio and video shortcodes. props rfair404. fixes #24820.

#5 @nacin
11 years ago

In 24858:

Update HTML classes in the audio and video shortcodes. props rfair404. fixes #24820.

Merges [24857] to the 3.6 branch.

Note: See TracTickets for help on using tickets.