WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24920 closed defect (bug) (fixed)

Remove unused global $pagenow in multiple files

Reported by: jeremyfelt's profile jeremyfelt Owned by: markjaquith's profile markjaquith
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

An unused $pagenow global is called via:

  • _wp_menu_output() in wp-admin/menu-header.php
  • media_upload_form() in wp-admin/includes/media.php
  • wp_link_pages in wp-includes/post-template.php

Attached patch removes these.

Attachments (1)

24920.diff​ (1.6 KB) - added by jeremyfelt 11 years ago.

Download all attachments as: .zip

Change History (3)

@jeremyfelt
11 years ago

#1 @nacin
11 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.7

#2 @markjaquith
11 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24974:

Remove $pagenow global from three functions that don’t use it.

Props jeremyfelt. Fixes #24920.

Note: See TracTickets for help on using tickets.