Notice using get_sample_permalink()

[juliobox]

Hello
This is about a Notice in get_sample_permalink(), here the core:

function get_sample_permalink($id, $title = null, $name = null) {
	$post = get_post($id);
	if ( !$post->ID )
		return array('', '');
...

So if the $id is not correct, the $post->ID will throw a Notice: Trying to get property of non-object in file.php on line n
I think we can use a simple "!$post" or "is_a( $post, 'WP_Post' ) )" here.
Thanks for reading

[alexvorn2]

this will slow the process of the function, just use a correct ID :D

[juliobox]

Are you serious? ... Please ... don't be that guy.
Replying to alexvorn2:

this will slow the process of the function, just use a correct ID :D

[rmccue]

This is a bug, not an enhancement. We should be checking the value of $post here, probably just changing the if statement to if ( ! $post || ! $post->ID )

[ocean90]

Can there be a post without an ID? ! $post should be enough.

[6983]/[6633]

---

alexvorn2, just stop it! That's not the first time.

[alexvorn2]

Replying to ocean90:

Can there be a post without an ID? ! $post should be enough.

[6983]/[6633]

---

alexvorn2, just stop it! That's not the first time.

to stop what? is this related to this ticket?

[markoheijnen]

$post is enough. Otherwise get_post() should be checked what it will return. That is also why is_a() isn't needed. Also if it was needed $post instanceof WP_Post would be faster.

[ocean90]

25005.patch​

• ! $post check for get_sample_permalink() and get_sample_permalink_html()
• Removes unused global $wpdb in get_sample_permalink_html()

[SergeyBiryukov]

In 25028:

Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005.