#25726 closed defect (bug) (fixed)
Hooks Docs: wp-admin/user-edit.php & 2 more files
Reported by: | admiralthrawn | Owned by: | kpdesign |
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Inline Docs | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
The files have documentation for:
wp-includes/ms-default-filters.php
wp-admin/user-edit.php
wp-admin/user-new.php
Attachments (3)
Change History (11)
#3
@
11 years ago
- Keywords has-patch added; needs-patch removed
25726.2.diff is a full pass through wp-admin/user-new.php and has some fixes for wp-admin/user-edit.php.
This should be good to go after a secondary review and recommendation.
#4
@
11 years ago
- Keywords needs-patch added; has-patch removed
@DrewAPicture: Thanks for the updated patch (25726.2.diff). Just a few changes needed, and we should be good:
user-new.php:
pre_user_login
:
- @since should be 2.0.3
autocomplete_users_for_site_admins
:
- @param description: s/Default is false./Default false.
user_new_form_tag
:
- Space out the action line (both instances).
show_password_fields
:
- @param description: s/Default is true./Default true.
user-edit.php:
personal_options_update
:
- @since should be 2.0.0
admin_color_scheme_picker
:
- Replace
6
withdo_action
in action line.
additional_capabilities_display
:
- @since should be 2.8.0
- @param for $enable - add "Default true." at end of description.
Could you make these changes and submit a new patch please? :)
#5
@
11 years ago
- Keywords has-patch commit added; needs-patch removed
- Milestone changed from Awaiting Review to 3.8
25726.3.diff applies the suggested changes in comment:4. I think that should do it.
#6
follow-up:
↓ 8
@
11 years ago
pre_user_login
should probably be documented in wp-includes/user.php
, along with other pre_user_*
filters: tags/3.7.1/src/wp-includes/user.php#L1325.
#8
in reply to:
↑ 6
@
11 years ago
Replying to SergeyBiryukov:
pre_user_login
should probably be documented inwp-includes/user.php
, along with otherpre_user_*
filters: tags/3.7.1/src/wp-includes/user.php#L1325.
Sorry, didn't see this comment before commit. I'll take a look a little later and adjust accordingly. Thanks :)
Would you mind regenerating your patch? It's coming through as malformed.