WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#25908 closed defect (bug) (fixed)

jshint shouldn't throw errors in twentyfourteen - wp-content/themes/js/functions.js

Reported by: jorbin's profile jorbin Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description


Attachments (1)

functions.jshint.diff​ (1.1 KB) - added by jorbin 12 years ago.

Download all attachments as: .zip

Change History (3)

@jorbin
12 years ago

#1 @lancewillett
12 years ago

  • Milestone changed from Awaiting Review to 3.8

Thanks for the patches and tickets, @jorbin. For next time it's OK for all 3 to be in 1 ticket
I think. :P

#2 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26084:

Twenty Fourteen: changes to JavaScript files to pass jshint, props jorbin. Fixes #25908 #25909 #25910.

  • Add global variable flags to top of JS files.
  • Group variable declarations correctly.
Note: See TracTickets for help on using tickets.