WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#25981 closed enhancement (fixed)

Appearance Themes: use Underscore.js throttle function instead of custom code to trigger pagination on scroll

Reported by: matveb's profile matveb Owned by: dd32's profile dd32
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Instead of building a custom throttling rely on _.throttle to trigger the infinite scroll rendering.

Attachments (1)

25981.diff​ (956 bytes) - added by matveb 11 years ago.

Download all attachments as: .zip

Change History (5)

@matveb
11 years ago

#1 @matveb
11 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.8

#3 @dd32
11 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 26467:

Themes: Use _.throttle() instead of a custom one. Props matveb. Fixes #25981

#4 @dd32
11 years ago

In 26468:

Themes: Add a clearing <br/> to the end of .theme-browser.
This is needed to cause the browser to render .theme-browser's height as it's true height, previously the reported height was 1*.theme which caused the Theme scroller to kick in immediately (as the threshold was less than 0).
See #25981 See #25948

Note: See TracTickets for help on using tickets.