Opened 11 years ago
Closed 11 years ago
#26255 closed defect (bug) (fixed)
Ensure all Style dependancies are set
Reported by: | dd32 | Owned by: | |
---|---|---|---|
Milestone: | 3.8 | Priority: | high |
Severity: | normal | Version: | 3.8 |
Component: | General | Keywords: | |
Focuses: | Cc: |
Description
This is a follow on to #26236
We need to ensure that all styles have their proper dependancies set prior to release, if something needs dashicons, it should be set as a dependancy, etc.
For dashicons specifically, here's a one-liner to list the files that refer to 'dashicons': (I'm sure it can be simplified)
find ./ -iname *.css | grep -v 'wp-content/' | sed "s/.\///" | xargs grep dashicons | sed "s/:.*$//g" | uniq
Attached is a patch that adds the dashicons dependancy to the remaining files, however, we should leave this ticket open and revisit at RC time.
Attachments (1)
Change History (5)
#4
@
11 years ago
- Resolution set to fixed
- Status changed from new to closed
I went by these guidelines:
- Dashicons needs to be a dependency everywhere it is used.
- Open Sans does *not* need to be a dependency everywhere.
Basically, Open Sans is for the admin. The toolbar, the installer screens, and the admin all need it. But I'm not sure using the media manager on the frontend requires Open Sans to work. (Of course, if Open Sans was installed on the computer, it'd load.)
In 26596: