Opened 11 years ago
Closed 11 years ago
#26260 closed defect (bug) (fixed)
Small typo
Reported by: | Latz | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | minor | Version: | 3.4 |
Component: | Text Changes | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
It's a question so there should be a question mark.
Attachments (2)
Change History (18)
#4
in reply to:
↑ 2
;
follow-ups:
↓ 5
↓ 6
@
11 years ago
Replying to Hanni:
I think "What would you like to call your network?" would be a question, whereas "What you would like to call your network." is a statement.
I think you read the patch backwards; the patch changes "." to "?", which looks right to me (it should be a question).
#5
in reply to:
↑ 4
;
follow-up:
↓ 7
@
11 years ago
Replying to rmccue:
I think you read the patch backwards; the patch changes "." to "?", which looks right to me (it should be a question).
Blerp, misread. Seems like Latz did the same, maybe this should be reworded?
#6
in reply to:
↑ 4
@
11 years ago
"'What you would like to call this network" is the text included. It's not particularly friendly, though.
#7
in reply to:
↑ 5
@
11 years ago
Replying to rmccue:
Replying to rmccue:
I think you read the patch backwards; the patch changes "." to "?", which looks right to me (it should be a question).
Blerp, misread. Seems like Latz did the same, maybe this should be reworded?
Aye, I hovered over it a few times on Sunday when editing the field below. The site title field in WP, not MultiSite doesn't even have a label, so I was in two minds about removing it, but then considered use on the network setup page. Will investigate.
#8
@
11 years ago
- Component changed from Network Admin to Text Changes
- Resolution invalid deleted
- Status changed from closed to reopened
- Version changed from trunk to 3.4
Related: #20314
There are some similar strings on Create a Network and Network Settings screens:
- Network Title / Network Name
- What would you like to call your network? / What you would like to call this network.
- Admin E-mail Address / Network Admin Email
Perhaps we should merge them.
#9
follow-up:
↓ 10
@
11 years ago
"What you would like to call this network." should probably be "This is what you would like to call this network."
#10
in reply to:
↑ 9
@
11 years ago
Replying to rmccue:
"What you would like to call this network." should probably be "This is what you would like to call this network."
That sounds a bit like a Star Wars reference to me :)
#11
@
11 years ago
The "What would you like to call your Network?" string on network.php (Create a Network) arguably has a different purpose to the string on the Network Settings page.
Looking at WP, "Site Title" doesn't have a description on install.php or at options-general.php. So, I'd suggest either they could be removed on both for maximum consistency, or just on the settings.php page.
The other strings (Network Title/Name, and Email) could be merged though?
#13
@
11 years ago
OK, here's a possible patch which both removes the potentially superfluous description field on settings.php and edits the email string on network.php to be " Network Admin Email" so as to be consistent. Note keeping "Email" as opposed to "E-mail" as per current efforts in #26156.
#15
@
11 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 3.8
26260.2.diff looks good to me.
I think "What would you like to call your network?" would be a question, whereas "What you would like to call your network." is a statement.