Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#26383 closed defect (bug) (fixed)

Twenty Fourteen: Menu toggle text causes a gap to the right of content

Reported by: kwight's profile kwight Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The .menu-toggle element contains text which is not contained by its parent, causing extra space to the right of content when below the 782px breakpoint.

text-indent is not an option as it would take the menu icon with it, and font-size cannot be zero as that causes issues with some mobile browsers. Therefore, the patch uses overflow: hidden.

Attachments (3)

26383.patch (376 bytes) - added by kwight 12 years ago.
before.png (114.1 KB) - added by kwight 12 years ago.
with-26383-patch.png (110.4 KB) - added by kwight 12 years ago.

Download all attachments as: .zip

Change History (8)

@kwight
12 years ago

#1 @kwight
12 years ago

  • Cc kwight@… added
  • Component changed from General to Bundled Theme
  • Keywords has-patch added

#2 @lancewillett
12 years ago

  • Milestone changed from Awaiting Review to 3.8

#3 @lancewillett
12 years ago

@kwight Thank you for the ticket and patch. For the sake of our future selves, could you please add before and after screenshots? Thanks.

#4 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26600:

Twenty Fourteen: avoid a potential gap in menu-toggle content. Props kwight, fixes #26383.

@kwight
12 years ago

#5 @kwight
12 years ago

While displaying properly on load, scrolling to the right reveals the extra space created by the menu toggle text.


With 26383.patch, the page loads properly, with no left/right scrolling possible.


[Editor's note: this is to document the original issue, not an additional bug report.]

Last edited 12 years ago by lancewillett (previous) (diff)
Note: See TracTickets for help on using tickets.