WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26444 closed defect (bug) (fixed)

Twenty Fourteen: remove `!important` declarations if possible

Reported by: lancewillett's profile lancewillett Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Audit and remove all !important declarations in CSS files.

Attachments (1)

26444.diff​ (2.8 KB) - added by lancewillett 11 years ago.

Download all attachments as: .zip

Change History (4)

@lancewillett
11 years ago

#1 @lancewillett
11 years ago

  • Version set to trunk

Based on research in core WP admin CSS, and Drupal (where the solution came from originally) I think it's safe to remove !important from our screen reader text elements.

The only one I still see as valid is the print CSS to remove any background color and image.

#3 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26689:

Twenty Fourteen: remove unneeded !important declarations, and comment the ones we absolutely need to keep around. Fixes #26444.

Note: See TracTickets for help on using tickets.