Ticket #3753 (closed enhancement: fixed)
Kubrick should allow comments for pages if check marked
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.9 |
| Component: | Template | Version: | 2.1 |
| Severity: | normal | Keywords: | theme kubrick page has-patch tested commit |
| Cc: | josephscott |
Description
Wordpress allow comments on pages. Everything in the code or the user interface indicate this.
Unfortunately it's impossible to add comments on a static page that allow them. At least it's impossible "out of the box" with default (aka Kubrick) theme.
My trivial patch add a comment form and comment list on every static page diplayed in Kubrick theme. This patch was tested on Wordpress 2.0.x and 2.1.
Attachments
-
wp-default-theme-show-comments-on-pages.diff
(298 bytes) -
added by Coolkevman 5 years ago.
- Patch to display comments on static page with Kubrick theme.
-
wp-default-theme-show-pages-comments-or-pingbacks.diff
(460 bytes) -
added by Coolkevman 5 years ago.
- Fix diff path. Sorry.
-
3753.diff
(413 bytes) -
added by Denis-de-Bernardy 3 years ago.
Change History
Coolkevman — 5 years ago
-
attachment
wp-default-theme-show-comments-on-pages.diff
added
comment:1
foolswisdom — 5 years ago
- Keywords has-patch, added
- Summary changed from Hidden coments on static pages to Kubrick should allow comments for pages if check marked
ENV: WP trunk (2.2-bleeding) r7842
Confirmed bug
Tested patch.
Coolkevman, Thank you! in the future please provide patches from the root of the project, so instead of the page file being for 'page.php' it is for 'wp-content/themes/default/page.php'
- Type changed from defect to enhancement
- Milestone changed from 2.1.1 to 2.2
comment:3
follow-up:
↓ 4
foolswisdom — 5 years ago
- Keywords page added; page, has-patch, comment removed
- Status changed from new to closed
- Resolution set to wontfix
- Milestone 2.2 deleted
Close WONTFIX.
Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)
comment:4
in reply to:
↑ 3
Coolkevman — 5 years ago
Replying to foolswisdom:
Close WONTFIX.
Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)
Ok, so if I understand a patch like the one I've just uploaded (wp-default-theme-show-pages-comments-or-pingbacks.diff) is not acceptable ?
Coolkevman — 5 years ago
-
attachment
wp-default-theme-show-pages-comments-or-pingbacks.diff
added
Fix diff path. Sorry.
comment:5
darkdragon — 4 years ago
- Status changed from closed to reopened
- Resolution wontfix deleted
- Milestone set to 2.5
Reopening for 2.5 to allow for patch to be debated again.
- Keywords tested commit added
- Milestone changed from 2.9 to 2.8
uploaded a refreshed patch against today's trunk. please commit this or wontfix it, so as to trim ticket clutter
- Status changed from reopened to closed
- Resolution set to wontfix
Kubrick has been like this forever.
I don't see a need to change this now.
comment:10
westi — 2 years ago
- Status changed from closed to reopened
- Resolution wontfix deleted
- Milestone changed from 2.8 to 2.9
For the theme repo we require support for Pages with Comments - http://codex.wordpress.org/Theme_Development_Checklist#Page_with_comments
Therefore default should do so as well.
Re-opening for 2.9.
comment:11
westi — 2 years ago
- Status changed from reopened to closed
- Resolution set to fixed
Patch to display comments on static page with Kubrick theme.