Opened 18 years ago
Closed 15 years ago
#3753 closed enhancement (fixed)
Kubrick should allow comments for pages if check marked
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 2.9 | Priority: | normal |
| Severity: | normal | Version: | 2.1 |
| Component: | Template | Keywords: | theme kubrick page has-patch tested commit |
| Focuses: | Cc: |
Description
Wordpress allow comments on pages. Everything in the code or the user interface indicate this.
Unfortunately it's impossible to add comments on a static page that allow them. At least it's impossible "out of the box" with default (aka Kubrick) theme.
My trivial patch add a comment form and comment list on every static page diplayed in Kubrick theme. This patch was tested on Wordpress 2.0.x and 2.1.
Attachments (3)
Change History (14)
#1
@
18 years ago
- Keywords has-patch added
- Summary changed from Hidden coments on static pages to Kubrick should allow comments for pages if check marked
ENV: WP trunk (2.2-bleeding) r7842
Confirmed bug
Tested patch.
Coolkevman, Thank you! in the future please provide patches from the root of the project, so instead of the page file being for 'page.php' it is for 'wp-content/themes/default/page.php'
#3
follow-up:
↓ 4
@
18 years ago
- Keywords has-patch comment removed
- Milestone 2.2 deleted
- Resolution set to wontfix
- Status changed from new to closed
Close WONTFIX.
Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)
#4
in reply to:
↑ 3
@
18 years ago
Replying to foolswisdom:
Close WONTFIX.
Noticed that for pages you would want to first check if
( comments_open() )because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)
Ok, so if I understand a patch like the one I've just uploaded (wp-default-theme-show-pages-comments-or-pingbacks.diff) is not acceptable ?
#5
@
17 years ago
- Milestone set to 2.5
- Resolution wontfix deleted
- Status changed from closed to reopened
Reopening for 2.5 to allow for patch to be debated again.
#7
@
16 years ago
- Keywords tested commit added
- Milestone changed from 2.9 to 2.8
uploaded a refreshed patch against today's trunk. please commit this or wontfix it, so as to trim ticket clutter
#8
@
16 years ago
- Resolution set to wontfix
- Status changed from reopened to closed
Kubrick has been like this forever.
I don't see a need to change this now.
#10
@
15 years ago
- Milestone changed from 2.8 to 2.9
- Resolution wontfix deleted
- Status changed from closed to reopened
For the theme repo we require support for Pages with Comments - http://codex.wordpress.org/Theme_Development_Checklist#Page_with_comments
Therefore default should do so as well.
Re-opening for 2.9.
Patch to display comments on static page with Kubrick theme.