Custom Permalinks Containing Categories Are Broken for Attachments

[mtekk]

Currently, with WordPress 2.2.1, when using a custom permalink structure containing the %category% tag, permalinks to attachment posts become broken. It seems to have something to do with the attachments having no category and thus cause the link to become broken.

Using the permalink scheme /archives/%category%/%postname%/ an example attachment 'bar' attached to the post 'foo' which happens to be in the general category results in the following broken permalink  http://sitename.com/archives/general/foo/bar/. The permalink makes sense, but doesn't work due to the attachment post not inheriting the category(ies) of the post it is attached to.

We're forcing %postname% (post slug) to be unique anyway, so we should probably just drop %category% from the query if %postname% is present. Actually, if %postname% is present, we can probably drop all other params.

what about comparing from left to right?

Replying to hakre:

what about comparing from left to right?

Thats not really a great fix, what if i used this as my permalink structure:

/archives/%postname%/%category%/

Ok its Unlikely someone would use that structure, but it shows that a left to right compare is just as useless

If we're forcing ALL post slugs to be unique, then to simplify it i'd agree that if %post_id% or %postname% is available(In that order) then it should ignore any other post-selectors in the url.

#6299 Gallery Permalinks using /%category%/%postname%/ return 404
was closed as a duplicate of this ticket.

Even if you skip the category_name query whenever the request is_singular, the permalink will break because %category% gobbles up slashes and prevents the rewrite rules from recognizing the attachment. Instead of doing an attachment query, a post query is done. We'd have to change single post queries to look for both posts and attachments.

Creating explicit attachment links as in #6280 might help.

I like the explicit attachment links idea. Also prevents the "feed.jpg" issue, if we weren't already dealing with that.

That patch gets us part of the way there, but the attachment rewrite rules aren't ordered early enough to prevent the category regex from claiming attachment as part of the category name.

put explicit rules first

(In [7531]) Fix attachment links for permalink structures containing category tag. Props andy. fixes #4699

regression test against 2.8 trunk successfully passed.