use wp_die instead of echo/exit pair

[nbachiyski]

In tow places in wp-admin errors are taken from WP_Error object and are just printed and the script ends.

Thus it is both not very beautoful and doesn't issue the correct encoding headers. Using wp_die solves both problems.

[westi]

+1 to the first change

Can we change admin-ajax.php like that as we a returning the error to js not the browser?

[ryan]

Maybe add a WP_Error::die_with_message() method?

[westi]

Replying to ryan:

Maybe add a WP_Error::die_with_message() method?

Cute

It might be nice if we can come up with something nice to replace the following:

if ( is_wp_error($result) )
{
    wp_die( $result->get_error_message() );
}

It would nice if all occurrances of the above could become oneliners like:

wp_die_if_wp_error($result);

[santosj]

if( is_wp_error( $result ) )
{
    $result->die_with_message('');
}

Pretty, short, and sweet

[Denis-de-Bernardy]

maybe even change is_wp_error() to die automatically?

[Denis-de-Bernardy]

can't find any trace of die statements in there.