WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

#5710 closed enhancement (fixed)

wp_tag_cloud should echo get_tag_cloud

Reported by: aaroncampbell's profile AaronCampbell Owned by: xenlab's profile xenlab
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: Template Keywords: has-patch tested early commit
Focuses: Cc:

Description

There should be a get_tag_cloud function that returns the string, rather than echoing it. wp_tag_cloud should use this new function, and apply filters, much like the_content uses get_the_content

Attachments (2)

5710.diff​ (880 bytes) - added by AaronCampbell 16 years ago.
5710.patch​ (785 bytes) - added by DD32 15 years ago.

Download all attachments as: .zip

Change History (17)

@AaronCampbell
16 years ago

#1 @thee17
16 years ago

Tested, This patch works well for me.

#2 @AaronCampbell
16 years ago

  • Keywords tested added; needs-testing removed
  • Milestone changed from 2.6 to 2.5

#3 @ffemtcj
16 years ago

  • Milestone changed from 2.5 to 2.6

#4 @AaronCampbell
16 years ago

  • Milestone changed from 2.6 to 2.5.1

#5 @ffemtcj
16 years ago

  • Milestone changed from 2.5.1 to 2.6

Please let the WP crew decide if they want to release this in a maintenance release.

#6 follow-up: @AaronCampbell
16 years ago

I didn't realize that only certain people were supposed to change that. If that's the case, I would recommend that we limit the ability. Also, how then do you draw attention to a ticket?

Anyway, to plead the case, it seems like this is perfect for a maintenance release. It fixes an inconsistency in the way functions in WP work, it has a patch already, and the patch has been tested.

#7 @AaronCampbell
15 years ago

  • Milestone changed from 2.9 to 2.7

#8 in reply to: ↑ 6 @jacobsantos
15 years ago

Replying to AaronCampbell:

I didn't realize that only certain people were supposed to change that. If that's the case, I would recommend that we limit the ability. Also, how then do you draw attention to a ticket?

Anyway, to plead the case, it seems like this is perfect for a maintenance release. It fixes an inconsistency in the way functions in WP work, it has a patch already, and the patch has been tested.

Something that is a feature, usually shouldn't be placed in a maintenance release. It is ultimately up to the core developers whether they want to or not.

#9 @AaronCampbell
15 years ago

I didn't move it into another maintenance release. I just brought it back from the deep dark depths of 2.9. I'd REALLY like to have a get_tag_cloud function so that I don't have to duplicate the function without the echo.

@DD32
15 years ago

#10 @DD32
15 years ago

  • Component changed from General to Template

attachment 5710.patch added.

  • Adds a 'echo' arg instead of a new function, setting that to 0 or false will return the content instead of echo'ing.

Given this is an Enhancement, It probably belongs in the 2.8 milestone due to being past the 2.7 feature freeze, But i'm going to leave it as is for someone else to decide.

#11 @jacobsantos
15 years ago

  • Keywords early added
  • Milestone changed from 2.7 to 2.8

This should be committed early for 2.8.

#12 @DD32
15 years ago

  • Keywords commit added
  • Version set to 2.7

Commit or Wontfix?

#13 @aaroncampbell
15 years ago

I'm happy with either solution, but the wontfix would be a bummer.

#14 @xenlab
15 years ago

  • Owner changed from anonymous to xenlab
  • Status changed from new to assigned

Taking this one on for the Super-Awesome WordPress 24-Hour Has-Patch Marathon. I will test the patch against 2.8 Head.

#15 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10946]) Add echo arg to tag cloud. Props DD32. fixes #5710

Note: See TracTickets for help on using tickets.