Wordpress default theme does not use correct background

[christmasboy81]

In 2.5 and 2.5.1, for the main page, the default theme (kubrick) uses kubrickbgwide.jpg for the background and not kubrickbg-ltr.jpg, like it should.

I did some research and the problem is in wp-content/themes/default/header.php and was broken in revision 6711, which was to fix ticket 3155.

The offending line is 17 and is currently

if ( !empty($withcomments) && !is_single() ) {

In the previous revision (6195) it was

if ( !$withcomments && !is_single() ) {

I think the correct change would be the following (although I know hardly anything about PHP or wordpress)

if ( empty($withcomments) && !is_single() ) {

This problem has been reported several times on the wordpress support forums. ​http://wordpress.org/support/topic/167648?replies=5 ​http://wordpress.org/support/topic/165580?replies=1 ​http://wordpress.org/support/topic/178600?replies=2

The title of the ticket should be "Wordpress default theme does not use correct background.

Sorry about that.

This bug doesn't seem to be existent with r8071.. my background is loaded from /wp-content/themes/default/images/kubrickbgcolor.jpg .

Replying to hansengel:

This bug doesn't seem to be existent with r8071.. my background is loaded from /wp-content/themes/default/images/kubrickbgcolor.jpg .

Sorry, this is related to the page background (where the content is), and not the body background.

The full code from header.php is:

15 	<?php
16 	// Checks to see whether it needs a sidebar or not
17 	if ( !empty($withcomments) && !is_single() ) {
18 	?>
19 	    #page { background: url("<?php bloginfo('stylesheet_directory'); ?>/images/kubrickbg-<?php bloginfo('text_direction'); ?>.jpg") repeat-y top; border: none; }
20 	<?php } else { // No sidebar ?>
21 	    #page { background: url("<?php bloginfo('stylesheet_directory'); ?>/images/kubrickbgwide.jpg") repeat-y top; border: none; }
22 	<?php } ?>

The result is that the entire body is the color of kubrickbgwide.jpg. kubrickbg-ltr.jpg has a colored area for the sidebar.

patch

He's right and so is his fix. Patch attached.

Tested on Ubuntu/Firefox + Opera. The background uses the correct jpg file.

(In [10949]) Fix logic inversion. Props christmasboy81. fixes #7121