Optimizations for atom_enclosures and rss_enclosures

[jacobsantos]

    $metadata = get_post_custom();

    if( isset($metadata['enclosure']) ) {
        foreach( (array) $metadata['enclosure'] as $enc ) {
            $enclosure = split("\n", $enc);
            echo apply_filters('atom_enclosure', '<link href="' . trim(htmlspecialchars($enclosure[0])) . '" rel="enclosure" length="' . trim($enclosure[1]) . '" type="' . trim($enclosure[2]) . '" />' . "\n");
        }
    }

Might be faster than

    foreach (get_post_custom() as $key => $val) {
        if ($key == 'enclosure') {
            foreach ((array)$val as $enc) {
                $enclosure = split("\n", $enc);
                echo apply_filters('atom_enclosure', '<link href="' . trim(htmlspecialchars($enclosure[0])) . '" rel="enclosure" length="' . trim($enclosure[1]) . '" type="' . trim($enclosure[2]) . '" />' . "\n");
            }
        }
    }

I'll create a patch later, my repository is dirty at the moment.

[DD32]

any reason

if( $encs = get_post_meta($post_id, 'enclosure') ) {
foreach()
}

cant be used? It seems just pulling the particular meta might be faster..

[jacobsantos]

I believe the reason get_post_custom() is that it already uses the global ID for the Loop. Using either one will be the same speed, but using your method, DD32, will use less memory as all of the metadata will need to be copied to the $metadata variable, whereas only the metadata that is needed is copied to $encs.

It is almost a moot point, since both functions pull from the metadata cache will get all of the metadata. The copy made in the function will be destroyed when the functions go out of scope however, so in the long run using get_post_meta() will be more memory efficient.

[Denis-de-Bernardy]

code is no longer around