Consistently use $wp_rewrite->index instead of hardcoding "index.php"

[markjaquith]

A few place in our URL generation and canonicalization code use hardcoded "index.php" instead of using $wp_rewrite->index

This prevents people from using custom PATHINFO permalinks.

[solarissmoke]

Is this still an issue?

[SergeyBiryukov]

Replying to solarissmoke:

Is this still an issue?

Yep, in some files:

• wp-admin/options-permalink.php
• wp-includes/canonical.php
• wp-includes/link-template.php
• wp-includes/nav-menu-template.php (maybe unrelated though)
• wp-includes/rewrite.php

[wonderboymusic]

Patched.

[wonderboymusic]

Moving to 3.6 for review

[markjaquith]

In 23305:

Consistently use $wp_rewrite->index instead of hardcoding "index.php".

props wonderboymusic. fixes #7337

[andrewryno]

This breaks _wp_menu_item_classes_by_context() in nav-menu-template.php.

Notice: Undefined variable: wp_rewrite in wp-includes/nav-menu-template.php on line 370
Notice: Trying to get property of non-object in wp-includes/nav-menu-template.php on line 370

Need $wp_rewrite to be global for it to work.

Not sure if it breaks other places, but this is the only one I've seen.

[wonderboymusic]

I wrote the patch a while ago, thanks for catching that :)

[ryan]

In 23309:

Declare wp_rewrite as global in _wp_menu_item_classes_by_context().

Props andrewryno
fixes #7337

[Viper007Bond]

Why not have a helper function that returns this value so that the $wp_rewrite global isn't needed? Much less prone to issues and doesn't require using global.

[andrewryno]

That would probably be better. Mine was a rather quick patch and I believe it's a global in other instances (and a global was already being defined for $wp_query) so it just made it seem more consistent.