curl_setopt() throws errors in safe mode

[Po0ky]

I'm getting the following error on each page.

Warning: curl_setopt() [function.curl-setopt]: CURLOPT_FOLLOWLOCATION cannot be activated when in safe_mode or an open_basedir is set in /**/wordpress/wp-includes/http.php on line 843

My best guess is there should be a check before running the curl-setopt function to check if safe mode is set or not.

[DD32]

Of course theres no mention of this on the Curl page from what i can see..

Thats not the first curl_setopt() call either, My only guess is its supposed to prevent the script from entering a endless loop? (because without CURLOPT_MAXREDIRS set, it'll follow as many as it wants -- which is done on the next line)

Perhaps, It'd be best to just not use the curl class at all in safe mode? (Its the 2nd preference for GET requests at present, not used for post?)

[ionfish]

Could just set CURLOPT_FOLLOWLOCATION only if safe mode isn't on.

[jacobsantos]

I need to turn on safe mode every once and a while while I run code probably.

[Po0ky]

check_safe_curl.patch

[Po0ky]

Hmpf, ignore my patch. I must be stupid or blind. :/

[santosj]

have you checked whether have it after the Max_redirs prevents the error?

[santosj]

I checked and this should go in.

[santosj]

One question, what does open_basedir have to do with whether FOLLOWLOCATION can be used? just because open_basedir is set doesn't mean safe_mode is also.

[ryan]

(In [8534]) Don't call curl_setopt() if safe_mode is enabled. Props ionfish and Po0ky. fixes #7458 see #4779

[santosj]

Oh right. The warning. That sucks.