Ticket #7797 (new enhancement)

Opened 4 years ago

Last modified 3 years ago

Consolidate iframe headers

Reported by: DD32 Owned by: anonymous
Priority: normal Milestone: Future Release
Component: Administration Version: 2.7
Severity: normal Keywords: needs-patch
Cc:

Description

Currently iframes are being used in multiple locations (ie. thickbox, plugin re-activation, etc) and in each case, theres generally a function for the header and footer, or its inline.

What i suggest, Is to create a standard set of admin templates which print the headers out for the pages.

And a side suggestion:
As an added bonus, It should probably be possible to automatically detect if it was loaded via thickbox ($_GET[TB_iframe] shouldnt be set) and serve the correct header (ie. Full admin side menu if no thickbox)

Change History

comment:1   DD32 — 4 years ago

The idea of automatically detecting if a thickbox page has been loaded via thickbox, and serving the correct header, has a downfall i just realised, The CSS of the thickbox pages really dont work that well with a full admin surounding them.. Worth a look though IMO.

I'll probably give this ticket a shot at some stage.

comment:2   DD32 — 4 years ago

(In [9141]) Plugin install from DD32. see #6015

Consolodated the plugin-installer iframe code and added a generic header to /wp-admin/includes/template.php which can probably be re-used for other parts as well.

comment:3   DD32 — 4 years ago

  • Milestone changed from 2.7 to 2.8

I'll leave full implementation until 2.8 for this.

comment:4   janeforshort — 3 years ago

  • Milestone changed from 2.8 to Future Release

Punting to be evaluated in next development cycle due to time constraints.

Note: See TracTickets for help on using tickets.