Dashboard comments approval doesn't update right now correctly

[westi]

Dashboard comments approval doesn't update right now correctly

Unapproved count changes, comment bubble changes approved count doesn't

See attached image

[westi]

Dashboard comments approval doesn't update right now correctly

[azaozz]

That could easily be added, but there's a localization issue when updating the numbers from Javascript.

For most languages the difference is only in the thousands separator 10,000 10.000 or 10 000, so the lower numbers of Spam and Pending are not affected. For the rest the problem is bigger.

Perhaps we could turn the update from js off and do it only on page reload when the numbers can be localized properly.

[markjaquith]

We need a better global solution for this, but no time for 2.7.

[Denis-de-Bernardy]

punting...

[Viper007Bond]

Replying to azaozz:

That could easily be added, but there's a localization issue when updating the numbers from Javascript.

Why not just use AJAX? On comment change via dashboard, refresh the counts (or even the whole "Right Now" widget via AJAX. That way PHP can handle generating the counts and everything.

[Denis-de-Bernardy]

see also #7753 and #7837

[caesarsgrunt]

Why not just leave the thousands separator out altogether? I believe this is acceptable in most locales, at least for numbers below 10,000, And it's certainly better to have an incorrectly formatted number than to have the wrong number.

Also, the localisation issue could conceivably affect the span and pending counts too, though it's true that they are unlikely to reach 1000...