Opened 4 years ago
Closed 4 years ago
#9225 closed defect (bug) (fixed)
PHP error in Magpie RSS feed export
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.8 |
| Component: | Feeds | Version: | 2.7 |
| Severity: | normal | Keywords: | has-patch tested commit |
| Cc: | vladimir@… |
Description
Using Wordpress 2.7.1
In the apache error log are many occurrences of these two lines:
Bad arguments. in /var/www/.../wp-includes/rss.php on line 175, The first argument, 'map_attrs', should be either NULL or a valid callback
The problem appears to be a simple coding error: the callback function should be called as array reference, array(object, user_func).
This patch solves the problem (against trunk, rev. 10641):
Index: rss.php
===================================================================
--- rss.php (revision 10641)
+++ rss.php (working copy)
@@ -170,7 +170,7 @@
{
// if tags are inlined, then flatten
$attrs_str = join(' ',
- array_map('map_attrs',
+ array_map(array($this, 'map_attrs'),
array_keys($attrs),
array_values($attrs) ) );
Attachments (1)
Change History (8)
- Milestone changed from Unassigned to 2.7.2
- Priority changed from high to normal
comment:2
Viper007Bond — 4 years ago
- Keywords has-patch needs-testing added; rss rss.php feed error removed
- Cc vladimir@… added
Denis-de-Bernardy — 4 years ago
- Keywords tested added; needs-testing removed
- Milestone changed from 2.7.2 to 2.8
- Keywords commit added
Note that as of 2.8, WordPress includes SimplePie, MagPie is no longer supported specifically.
This sounds like something that should be submitted upstream, however, I'm not too sure on if that support still even exists (I don't think so)
Might as well get this commited for those who end up using it, with the note that Magpie is dead.
nod. I figured many plugins are still using it, and will continue to use it, for a very long time.
Erm...
Should be array_map(&$this, 'map_attrs') - note ampersand in front of this.