Ticket #9436 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

'the_tags' filter not applied on the_tags() function

Reported by: scribu Owned by:
Priority: normal Milestone: 2.8
Component: Taxonomy Version: 2.5
Severity: normal Keywords: has-patch
Cc: scribu@…

Description

When you call the_tags() this is what happens:

the_tags() => the_terms() => get_the_term_list() => apply_filters( "term_links-$taxonomy")

But 'the_tags' filter is called in get_tags_list().

This is how it should be:

the_tags() => get_tags_list()

Attachments

the_tags.patch Download (751 bytes) - added by scribu 3 years ago.
Also pass the arguments to the filter

Change History

  • Cc scribu@… added

scribu3 years ago

Also pass the arguments to the filter

  • Owner changed from anonymous to ryan
  • Component changed from General to Taxonomy
  • Owner ryan deleted

+1 But I believe this goes back as far as 2.5, maybe further.

  • Version changed from 2.8 to 2.5

You're right. All the more reason to fix it. :)

I came up with an almost identical fix to the patch scribu posted before I knew this ticket existed. I've tested his patch on 2.5.1 and 2.8-svn, but nothing in between. Can someone qualified tag this as (tested|needs-testing|commit)?

comment:7   ryan3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10888]) Invoke the_tags filter in the_tags(). Props scribu. fixes #9436

Note: See TracTickets for help on using tickets.