Better filtering for image_downsize()

[scribu]

Currently, the image_downsize filter doesn't pass the computed data array.

So, for example, if a plugin wants only to change the image src, it has to copy the entire image_downsize() function in order to compute the other fields: $width, $heigh and $is_intermediate.

[scribu]

apply the filter at the end

[Denis-de-Bernardy]

the current patch changes the semantics of the existing patch. if a plugin relies on it and checks for !== false before doing its stuff, that plugin will break. so we might want to use add a different hook instead.

[scribu]

Replying to Denis-de-Bernardy:

the current patch changes the semantics of the existing patch. if a plugin relies on it and checks for !== false before doing its stuff, that plugin will break. so we might want to use add a different hook instead.

If the plugin relies on !== false, it means that it will also conflict with another plugin that uses the hook.

So it's not a very good plugin, not because of it's author, but because of the suboptimal way this filter has been applied. Hence the need for this patch.

[scribu]

So, to answer your concern, I think it should be the same hook, so that plugin authors are not tempted to rely on quirky behaviour.

[Denis-de-Bernardy]

Well, not exactly. If I were to hook onto the existing hook, personally, I'd make sure I don't change something that has already been generate -- so as to *not* conflict with existing plugins.

But I seem your point, yeah.

[Denis-de-Bernardy]

patch still works against trunk. please commit or wontfix to trim ticket clutter.

[azaozz]

There are hooks like that in several places. They allow a plugin to skip the rest of the function by providing output (similar to how pluggable.php works).

Not sure what the end result will be if there are 3-4 plugins all doing image_downsize at the same time...

[scribu]

Replying to azaozz:

There are hooks like that in several places. They allow a plugin to skip the rest of the function by providing output (similar to how pluggable.php works).

Not sure what the end result will be if there are 3-4 plugins all doing image_downsize at the same time...

Ok, I'm obviously barking at the wrong tree. This probably isn't the hook I should be using anyway.