wp_crop_image() and image_resize() are inconsistent. Both should return WP_Error objects on error.

[mdawaffe]

wp_crop_image() returns a string on error. resize_image() returns a WP_Error object.

Both use wp_load_image() and should have consistent return values.

Attached. Assigned to 2.9. 2.8?

I also think wp_load_image() should return a WP_Error object instead of a string on error, but maybe that's a separate ticket.

[Denis-de-Bernardy]

+1

[westi]

This sounds like a good idea to me.

I am wary of changing the return value of a function this close to release - would have rather done this pre-beta to make sure plugin authors had a chance to catch anywhere they are relying on current behaviour.

We should also change wp_load_image to return a WP_Error at the same time I agree.

[ryan]

(In [12524]) Retunr WP_Error from wp_crop_image() and image_resize(). Props mdwaffe. fixes #9922