Changeset 63161

Timestamp:

08/09/2026 06:49:43 PM (4 hours ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertNull() instead of assertSame() with null.

Using the dedicated assertNull() assertion instead of assertSame( null, $actual ) clarifies intent and produces more descriptive failure messages.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/12818.

Follow-up to r62969.

Props Soean.
See #64894.

Location:

trunk/tests/phpunit/tests

Files:

• functions/maybeSerialize.php (modified) (1 diff)
• post/types.php (modified) (1 diff)
• post/wpAfterInsertPost.php (modified) (2 diffs)
• rest-api/rest-settings-controller.php (modified) (1 diff)
• theme/wpGetBlockCssSelector.php (modified) (5 diffs)

trunk/tests/phpunit/tests/functions/maybeSerialize.php

@@ -223 +223 @@
                         $callback_value = $property->getValue( $new_value );
 
-                        $this->assertSame( null, $callback_value );
+                        $this->assertNull( $callback_value );
                 } else {
                         $this->assertSame( $value->count(), unserialize( $serialized )->count() );

trunk/tests/phpunit/tests/post/types.php

@@ -627 +627 @@
                 remove_post_type_support( 'foo', 'autosave' );
                 $post_type_object = get_post_type_object( 'foo' );
-                $this->assertSame( null, $post_type_object->get_autosave_rest_controller(), 'Autosave controller should be removed.' );
+                $this->assertNull( $post_type_object->get_autosave_rest_controller(), 'Autosave controller should be removed.' );
                 _unregister_post_type( 'foo' );
         }

trunk/tests/phpunit/tests/post/wpAfterInsertPost.php

@@ -158 +158 @@
                 );
 
-                $this->assertSame( null, self::$passed_post_before_status );
+                $this->assertNull( self::$passed_post_before_status );
                 $this->assertSame( 'a new post', self::$passed_post_title );
         }
@@ -198 +198 @@
                 rest_get_server()->dispatch( $request );
 
-                $this->assertSame( null, self::$passed_post_before_title );
+                $this->assertNull( self::$passed_post_before_title );
                 $this->assertSame( 'new title', self::$passed_post_title );
         }

trunk/tests/phpunit/tests/rest-api/rest-settings-controller.php

@@ -795 +795 @@
                 $this->assertSame( 'Title', $title['title'] );
                 $this->assertSame( 'Site title.', $title['description'] );
-                $this->assertSame( null, $title['default'] );
+                $this->assertNull( $title['default'] );
         }
 }

trunk/tests/phpunit/tests/theme/wpGetBlockCssSelector.php

@@ -132 +132 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertSame( null, $selector );
+                $this->assertNull( $selector );
         }
 
@@ -206 +206 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertSame( null, $selector );
+                $this->assertNull( $selector );
         }
 
@@ -263 +263 @@
 
                 $selector = wp_get_block_css_selector( $block_type, array( 'typography', 'fontSize' ) );
-                $this->assertSame( null, $selector );
+                $this->assertNull( $selector );
         }
 
@@ -298 +298 @@
                         array( 'typography', 'fontSize' )
                 );
-                $this->assertSame( null, $selector );
+                $this->assertNull( $selector );
         }
 
@@ -312 +312 @@
 
                 $selector = wp_get_block_css_selector( $block_type, array() );
-                $this->assertSame( null, $selector );
+                $this->assertNull( $selector );
 
                 $selector = wp_get_block_css_selector( $block_type, '' );
-                $this->assertSame( null, $selector );
+                $this->assertNull( $selector );
         }