Changeset 62969

Timestamp:

08/02/2026 11:48:34 PM (7 days ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertTrue()/assertFalse() instead of assertSame() with booleans.

Using the dedicated boolean assertions clarifies intent and produces more descriptive failure messages.

Follow-up to [51453].

Props Soean, mukesh27.
See #64894.

Location:

trunk/tests/phpunit/tests

Files:

• blocks/wpBlockType.php (modified) (3 diffs)
• interactivity-api/wpInteractivityAPI-wp-bind.php (modified) (2 diffs)
• rest-api/rest-post-meta-fields.php (modified) (1 diff)
• rest-api/wpRestMenusController.php (modified) (1 diff)

trunk/tests/phpunit/tests/blocks/wpBlockType.php

@@ -529 +529 @@
                 );
 
-                $this->assertSame( false, $callback_called, 'The callback should not be called before the variations are accessed.' );
+                $this->assertFalse( $callback_called, 'The callback should not be called before the variations are accessed.' );
                 $block_type->variations; // access the variations.
-                $this->assertSame( true, $callback_called, 'The callback should be called when the variations are accessed.' );
+                $this->assertTrue( $callback_called, 'The callback should be called when the variations are accessed.' );
         }
 
@@ -556 +556 @@
                 // If the variations are defined after registration but before first access, the callback should not override it.
                 $this->assertSameSets( $test_variations, $block_type->get_variations(), 'Variations are same as variations set' );
-                $this->assertSame( false, $callback_called, 'The callback was never called.' );
+                $this->assertFalse( $callback_called, 'The callback was never called.' );
         }
 
@@ -618 +618 @@
                 $obtained_variations = $block_type->variations; // access the variations.
 
-                $this->assertSame( true, $callback_called, 'The callback should be called when the variations are accessed.' );
+                $this->assertTrue( $callback_called, 'The callback should be called when the variations are accessed.' );
                 $this->assertSameSets( $obtained_variations, $expected_variations, 'The variations obtained from the callback should be filtered.' );
         }

trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-bind.php

@@ -455 +455 @@
                 $html    = '<div data-wp-bind--id="myPlugin::state.trueValue"></div>';
                 list($p) = $this->process_directives( $html );
-                $this->assertSame( true, $p->get_attribute( 'id' ) );
+                $this->assertTrue( $p->get_attribute( 'id' ) );
         }
 
@@ -468 +468 @@
                 $html    = '<div data-wp-bind--id="myPlugin::state.trueValue"></div>';
                 list($p) = $this->process_directives( $html );
-                $this->assertSame( true, $p->get_attribute( 'id' ) );
+                $this->assertTrue( $p->get_attribute( 'id' ) );
 
                 $html    = '<div data-wp-bind--id---unique-id="myPlugin::state.trueValue"></div>';

trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

@@ -2349 +2349 @@
 
                 $data = $response->get_data();
-                $this->assertSame( false, $data['meta']['authenticated'] );
+                $this->assertFalse( $data['meta']['authenticated'] );
         }
 

trunk/tests/phpunit/tests/rest-api/wpRestMenusController.php

@@ -317 +317 @@
                 $this->assertSame( 'New Name', $data['name'] );
                 $this->assertSame( 'New Description', $data['description'] );
-                $this->assertSame( true, $data['auto_add'] );
+                $this->assertTrue( $data['auto_add'] );
                 $this->assertSame( 'new-name', $data['slug'] );
                 $this->assertSame( 'just meta', $data['meta']['test_single_menu'] );