Changeset 14153 for trunk/wp-admin/export.php

Timestamp:

04/18/2010 02:51:55 PM (15 years ago)

Author:

nacin

Message:

Optimize the Authors drop-down in export.php. Makes it one query, also orders authors by display name. see #10317.

File:

• trunk/wp-admin/export.php (modified) (1 diff)

trunk/wp-admin/export.php

@@ -88 +88 @@
 <option value="all" selected="selected"><?php _e('All Authors'); ?></option>
 <?php
-$authors = $wpdb->get_col( "SELECT post_author FROM $wpdb->posts GROUP BY post_author" );
-foreach ( $authors as $id ) {
-    $o = get_userdata( $id );
-    echo "<option value='{$o->ID}'>{$o->display_name}</option>\n";
-}
+$authors = $wpdb->get_results( "SELECT DISTINCT u.id, u.display_name FROM $wpdb->users u INNER JOIN $wpdb->posts p ON u.id = p.post_author ORDER BY u.display_name" );
+foreach ( (array) $authors as $author )
+       echo "<option value='{$author->id}'>{$author->display_name}</option>\n";
 ?>
 </select>