Changeset 15287 for trunk/wp-admin/includes/plugin-install.php

Timestamp:

06/19/2010 07:28:27 AM (14 years ago)

Author:

dd32

Message:

Move plugin installer install_popular_tags() to use a site transient rather than its own caching logic. Fixes #13108

File:

• trunk/wp-admin/includes/plugin-install.php (modified) (2 diffs)

trunk/wp-admin/includes/plugin-install.php

@@ -66 +66 @@
  */
 function install_popular_tags( $args = array() ) {
-    if ( ! ($cache = wp_cache_get('popular_tags', 'api')) && ! ($cache = get_option('wporg_popular_tags')) )
-        add_option('wporg_popular_tags', array(), '', 'no'); ///No autoload.
-
-    if ( $cache && $cache->timeout + 3 * 60 * 60 > time() )
-        return $cache->cached;
+    $key = md5(serialize($args));
+    if ( false !== ($tags = get_site_transient('poptags_' . $key) ) )
+        return $tags;
 
     $tags = plugins_api('hot_tags', $args);
@@ -77 +75 @@
         return $tags;
 
-    $cache = (object) array('timeout' => time(), 'cached' => $tags);
-
-    update_option('wporg_popular_tags', $cache);
-    wp_cache_set('popular_tags', $cache, 'api');
+    set_site_transient('poptags_' . $key, $tags, 10800); // 3 * 60 * 60 = 10800
 
     return $tags;