Changeset 18954

Timestamp:

10/12/2011 08:30:50 PM (12 years ago)

Author:

ryan

Message:

Die when attempting to edit non-existent term. Props johnbillion. fixes #18718

File:

• trunk/wp-admin/edit-tags.php (modified) (2 diffs)

trunk/wp-admin/edit-tags.php

@@ -114 +114 @@
     $title = $tax->labels->edit_item;
 
+    $tag_ID = (int) $_REQUEST['tag_ID'];
+
+    $tag = get_term( $tag_ID, $taxonomy, OBJECT, 'edit' );
+    if ( ! $tag )
+        wp_die( __( 'You attempted to edit an item that doesn’t exist. Perhaps it was deleted?' ) );
     require_once ( 'admin-header.php' );
-    $tag_ID = (int) $_REQUEST['tag_ID'];
-
-    $tag = get_term( $tag_ID, $taxonomy, OBJECT, 'edit' );
     include( './edit-tag-form.php' );
 
@@ -128 +130 @@
     if ( !current_user_can( $tax->cap->edit_terms ) )
         wp_die( __( 'Cheatin’ uh?' ) );
+ 
+    $tag = get_term( $tag_ID, $taxonomy ); 
+    if ( ! $tag )
+        wp_die( __( 'You attempted to edit an item that doesn’t exist. Perhaps it was deleted?' ) );
 
     $ret = wp_update_term( $tag_ID, $taxonomy, $_POST );