Changeset 20384

Timestamp:

04/06/2012 08:47:24 PM (13 years ago)

Author:

ryan

Message:

Make choosing a header image from the media library play nicely with file replication plugins that do not guarantee images will be retained in the local filesystem.

• When passing an attachment ID to wp_crop_image(), use load_image_to_edit() to fetch the image via a url fopen when the image does not exist in the filesystem.
• Move load_image_to_edit() to wp-admin/includes/image.php so that it is always available for admin pages loads.
• Fallback to the height and width stored in the attachment meta when the image no longer exists in the filesystem.

see #19840

Location:

trunk/wp-admin

Files:

• custom-header.php (modified) (3 diffs)
• includes/image-edit.php (modified) (1 diff)
• includes/image.php (modified) (4 diffs)

trunk/wp-admin/custom-header.php

@@ -701 +701 @@
         }
 
-        list($width, $height, $type, $attr) = getimagesize( $file );
+        if ( file_exists( $file ) ) {
+            list( $width, $height, $type, $attr ) = getimagesize( $file );
+        } else {
+            $data = wp_get_attachment_metadata( $id );
+            $height = $data[ 'height' ];
+            $width = $data[ 'width' ];
+            unset( $data );
+        }
 
         $max_width = 0;
@@ -717 +724 @@
         {
             // Add the meta-data
-            wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) );
+            if ( file_exists( $file ) )
+                wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) );
             update_post_meta( $id, '_wp_attachment_is_custom_header', get_option('stylesheet' ) );
 
@@ -725 +733 @@
         } elseif ( $width > $max_width ) {
             $oitar = $width / $max_width;
-            $image = wp_crop_image($file, 0, 0, $width, $height, $max_width, $height / $oitar, false, str_replace(basename($file), 'midsize-'.basename($file), $file));
+            $image = wp_crop_image($id, 0, 0, $width, $height, $max_width, $height / $oitar, false, str_replace(basename($file), 'midsize-'.basename($file), $file));
             if ( is_wp_error( $image ) )
                 wp_die( __( 'Image could not be processed. Please go back and try again.' ), __( 'Image Processing Error' ) );

trunk/wp-admin/includes/image-edit.php

@@ -196 +196 @@
     </div>
 <?php
-}
-
-function load_image_to_edit($post_id, $mime_type, $size = 'full') {
-    $filepath = get_attached_file($post_id);
-
-    if ( $filepath && file_exists($filepath) ) {
-        if ( 'full' != $size && ( $data = image_get_intermediate_size($post_id, $size) ) ) {
-            $filepath = apply_filters('load_image_to_edit_filesystempath', path_join( dirname($filepath), $data['file'] ), $post_id, $size);
-        }
-    } elseif ( function_exists('fopen') && function_exists('ini_get') && true == ini_get('allow_url_fopen') ) {
-        $filepath = apply_filters('load_image_to_edit_attachmenturl', wp_get_attachment_url($post_id) , $post_id, $size);
-    }
-
-    $filepath = apply_filters('load_image_to_edit_path', $filepath, $post_id, $size);
-    if ( empty($filepath) )
-        return false;
-
-    switch ( $mime_type ) {
-        case 'image/jpeg':
-            $image = imagecreatefromjpeg($filepath);
-            break;
-        case 'image/png':
-            $image = imagecreatefrompng($filepath);
-            break;
-        case 'image/gif':
-            $image = imagecreatefromgif($filepath);
-            break;
-        default:
-            $image = false;
-            break;
-    }
-    if ( is_resource($image) ) {
-        $image = apply_filters('load_image_to_edit', $image, $post_id, $size);
-        if ( function_exists('imagealphablending') && function_exists('imagesavealpha') ) {
-            imagealphablending($image, false);
-            imagesavealpha($image, true);
-        }
-    }
-    return $image;
 }
 

trunk/wp-admin/includes/image.php

@@ -44 +44 @@
  * @return string|WP_Error|false New filepath on success, WP_Error or false on failure.
  */
-function wp_crop_image( $src_file, $src_x, $src_y, $src_w, $src_h, $dst_w, $dst_h, $src_abs = false, $dst_file = false ) {
-    if ( is_numeric( $src_file ) ) // Handle int as attachment ID
-        $src_file = get_attached_file( $src_file );
-
-    $src = wp_load_image( $src_file );
-
-    if ( !is_resource( $src ) )
+function wp_crop_image( $src, $src_x, $src_y, $src_w, $src_h, $dst_w, $dst_h, $src_abs = false, $dst_file = false ) {
+    if ( is_numeric( $src ) ) { // Handle int as attachment ID
+        $src_file = get_attached_file( $src );
+        if ( ! file_exists( $src_file ) ) {
+            // If the file doesn't exist, attempt a url fopen on the src link.
+            // This can occur with certain file replication plugins.
+            $post = get_post( $src );
+            $src = load_image_to_edit( $src, $post->post_mime_type, 'full' );
+        } else {
+            $src = wp_load_image( $src_file );
+        }
+    } else {
+        $src = wp_load_image( $src_file );
+    }
+
+    if ( ! is_resource( $src ) )
         return new WP_Error( 'error_loading_image', $src, $src_file );
 
@@ -60 +69 @@
     }
 
-    if (function_exists('imageantialias'))
+    if ( function_exists( 'imageantialias' ) )
         imageantialias( $dst, true );
 
@@ -71 +80 @@
 
     $dst_file = preg_replace( '/\\.[^\\.]+$/', '.jpg', $dst_file );
+
+    // The directory containing the original file may no longer exist when
+    // using a replication plugin.
+    wp_mkdir_p( dirname( $dst_file ) );
 
     if ( imagejpeg( $dst, $dst_file, apply_filters( 'jpeg_quality', 90, 'wp_crop_image' ) ) )
@@ -340 +353 @@
     return apply_filters('file_is_displayable_image', $result, $path);
 }
+
+function load_image_to_edit($post_id, $mime_type, $size = 'full') {
+    $filepath = get_attached_file($post_id);
+
+    if ( $filepath && file_exists($filepath) ) {
+        if ( 'full' != $size && ( $data = image_get_intermediate_size($post_id, $size) ) ) {
+            $filepath = apply_filters('load_image_to_edit_filesystempath', path_join( dirname($filepath), $data['file'] ), $post_id, $size);
+        }
+    } elseif ( function_exists('fopen') && function_exists('ini_get') && true == ini_get('allow_url_fopen') ) {
+        $filepath = apply_filters('load_image_to_edit_attachmenturl', wp_get_attachment_url($post_id) , $post_id, $size);
+    }
+
+    $filepath = apply_filters('load_image_to_edit_path', $filepath, $post_id, $size);
+    if ( empty($filepath) )
+        return false;
+
+    switch ( $mime_type ) {
+        case 'image/jpeg':
+            $image = imagecreatefromjpeg($filepath);
+            break;
+        case 'image/png':
+            $image = imagecreatefrompng($filepath);
+            break;
+        case 'image/gif':
+            $image = imagecreatefromgif($filepath);
+            break;
+        default:
+            $image = false;
+            break;
+    }
+    if ( is_resource($image) ) {
+        $image = apply_filters('load_image_to_edit', $image, $post_id, $size);
+        if ( function_exists('imagealphablending') && function_exists('imagesavealpha') ) {
+            imagealphablending($image, false);
+            imagesavealpha($image, true);
+        }
+    }
+    return $image;
+}