Changeset 20592

Timestamp:

04/25/2012 07:37:19 PM (13 years ago)

Author:

nacin

Message:

Reduce clutter and repetive functionality from the initial landing page for installing plugins and themes by removing the tag/author/term dropdown.

The tag cloud (plugins) and feature filter (themes) is sufficient for tag functionality. All three "search by" fields are already weighted for a standard keyword search through the WP.org API.

fixes #19619 for 3.4.

Location:

trunk/wp-admin/includes

Files:

• class-wp-plugin-install-list-table.php (modified) (1 diff)
• class-wp-theme-install-list-table.php (modified) (1 diff)
• plugin-install.php (modified) (4 diffs)
• theme-install.php (modified) (3 diffs)

trunk/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -63 +63 @@
                 }
 
-                add_action( 'install_plugins_table_header', 'install_search_form' );
+                add_action( 'install_plugins_table_header', 'install_search_form', 10, 0 );
                 break;
 

trunk/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -79 +79 @@
                 }
 
-                add_action( 'install_themes_table_header', 'install_theme_search_form' );
+                add_action( 'install_themes_table_header', 'install_theme_search_form', 10, 0 );
                 break;
 

trunk/wp-admin/includes/plugin-install.php

@@ -85 +85 @@
 
     <h4><?php _e('Search') ?></h4>
-    <p class="install-help"><?php _e('Search for plugins by keyword, author, or tag.') ?></p>
-    <?php install_search_form(); ?>
+    <?php install_search_form( false ); ?>
 
     <h4><?php _e('Popular tags') ?></h4>
@@ -117 +116 @@
  * @since 2.7.0
  */
-function install_search_form(){
+function install_search_form( $type_selector = true ) {
     $type = isset($_REQUEST['type']) ? stripslashes( $_REQUEST['type'] ) : '';
     $term = isset($_REQUEST['s']) ? stripslashes( $_REQUEST['s'] ) : '';
@@ -123 +122 @@
     ?><form id="search-plugins" method="get" action="">
         <input type="hidden" name="tab" value="search" />
+        <?php if ( $type_selector ) : ?>
         <select name="type" id="typeselector">
             <option value="term"<?php selected('term', $type) ?>><?php _e('Keyword'); ?></option>
@@ -128 +128 @@
             <option value="tag"<?php selected('tag', $type) ?>><?php _ex('Tag', 'Plugin Installer'); ?></option>
         </select>
+        <?php endif; ?>
         <input type="search" name="s" value="<?php echo esc_attr($term) ?>" />
         <label class="screen-reader-text" for="plugin-search-input"><?php _e('Search Plugins'); ?></label>

trunk/wp-admin/includes/theme-install.php

@@ -50 +50 @@
  * @since 2.8.0
  */
-function install_theme_search_form() {
+function install_theme_search_form( $type_selector = true ) {
     $type = isset( $_REQUEST['type'] ) ? stripslashes( $_REQUEST['type'] ) : '';
     $term = isset( $_REQUEST['s'] ) ? stripslashes( $_REQUEST['s'] ) : '';
+    if ( ! $type_selector )
+        echo '<p class="install-help">' . __( 'Search for themes by keyword.' ) . '</p>';
     ?>
-<p class="install-help"><?php _e('Search for themes by keyword, author, or tag.') ?></p>
-
 <form id="search-themes" method="get" action="">
     <input type="hidden" name="tab" value="search" />
+    <?php if ( $type_selector ) : ?>
     <select name="type" id="typeselector">
     <option value="term" <?php selected('term', $type) ?>><?php _e('Keyword'); ?></option>
@@ -63 +64 @@
     <option value="tag" <?php selected('tag', $type) ?>><?php _ex('Tag', 'Theme Installer'); ?></option>
     </select>
+    <?php endif; ?>
     <input type="search" name="s" size="30" value="<?php echo esc_attr($term) ?>" />
     <?php submit_button( __( 'Search' ), 'button', 'search', false ); ?>
@@ -75 +77 @@
  */
 function install_themes_dashboard() {
-    install_theme_search_form();
+    install_theme_search_form( false );
 ?>
 <h4><?php _e('Feature Filter') ?></h4>
-<p class="install-help"><?php _e('Find a theme based on specific features') ?></p>
+<p class="install-help"><?php _e( 'Find a theme based on specific features.' ); ?></p>
 
 <form method="get" action="">