Changeset 23874 for trunk/wp-admin/includes/post-formats.php

Timestamp:

03/29/2013 08:56:18 PM (12 years ago)

Author:

helen

Message:

Since post format meta for images now takes an attachment ID only, make sure we label it appropriately and don't do things like esc_url() the value. fixes #23900.

File:

• trunk/wp-admin/includes/post-formats.php (modified) (2 diffs)

trunk/wp-admin/includes/post-formats.php

@@ -21 +21 @@
     <?php
     $image = false;
-    if ( isset( $format_meta['image'] ) )
-        $image = is_numeric( $format_meta['image'] ) ? wp_get_attachment_url( $format_meta['image'] ) : $format_meta['image'];
+    if ( ! empty( $format_meta['image'] ) && is_numeric( $format_meta['image'] ) ) {
+        $format_meta['image'] = absint( $format_meta['image'] );
+        $image = wp_get_attachment_url( $format_meta['image'] );
+    }
     ?>
     <div class="field wp-format-image">
@@ -37 +39 @@
             </a>
         </div>
-        <label for="_wp_format_image" class="screen-reader-text"><?php _e( 'Image URL' ); ?>:</label>
-        <input id="wp_format_image" type="hidden" name="_wp_format_image" value="<?php echo esc_url( $format_meta['image'] ); ?>" placeholder="<?php esc_attr_e( 'Image URL' ); ?>" class="widefat" />
+        <label for="_wp_format_image" class="screen-reader-text"><?php _e( 'Attachment ID' ); ?>:</label>
+        <input id="wp_format_image" type="hidden" name="_wp_format_image" value="<?php esc_attr_e( $format_meta['image'] ); ?>" placeholder="<?php esc_attr_e( 'Attachment ID' ); ?>" class="widefat" />
     </div>