Changeset 26205

Timestamp:

11/15/2013 05:55:24 AM (11 years ago)

Author:

nacin

Message:

Fix JSHint errors in plupload handlers.js.

props mdbitz.
fixes #26041.

File:

• trunk/src/wp-includes/js/plupload/handlers.js (modified) (11 diffs)

trunk/src/wp-includes/js/plupload/handlers.js

@@ +1 @@
+/* global plupload, pluploadL10n, ajaxurl, post_id, wpUploaderInit, deleteUserSetting, setUserSetting, getUserSetting */
+/* global resize_width, resize_height, shortform */
 var topWin = window.dialogArguments || opener || parent || top, uploader, uploader_init;
-
-function fileDialogStart() {
-    jQuery("#media-upload-error").empty();
-}
 
 // progress and success handlers for media multi uploads
@@ -50 +48 @@
     if ( max > hundredmb && file.size > hundredmb ) {
         setTimeout(function(){
-            var done;
-
-            if ( file.status < 3 && file.loaded == 0 ) { // not uploading
+            
+            if ( file.status < 3 && file.loaded === 0 ) { // not uploading
                 wpFileError(file, pluploadL10n.big_upload_failed.replace('%1$s', '<a class="uploader-html" href="#">').replace('%2$s', '</a>'));
                 up.stop(); // stops the whole queue
@@ -107 +104 @@
     if ( arg ) {
         if ( uploader.features.jpgresize )
-            uploader.settings['resize'] = { width: resize_width, height: resize_height, quality: 100 };
+            uploader.settings.resize = { width: resize_width, height: resize_height, quality: 100 };
         else
             uploader.settings.multipart_params.image_resize = true;
@@ -130 +127 @@
         prepareMediaItemInit(fileObj);
     } else { // New style: server data is just the attachment ID, fetch the thumbnail and form html from the server
-        item.load('async-upload.php', {attachment_id:serverData, fetch:f}, function(){prepareMediaItemInit(fileObj);updateMediaForm()});
+        item.load('async-upload.php', {attachment_id:serverData, fetch:f}, function(){prepareMediaItemInit(fileObj);updateMediaForm();});
     }
 }
@@ -172 +169 @@
                 _ajax_nonce: this.href.replace(/^.*wpnonce=/,'')
             },
-            success: function(data, textStatus){
-                var item = jQuery('#media-item-' + fileObj.id);
-
+            success: function( ){
+                var type,
+                    item = jQuery('#media-item-' + fileObj.id);
+                
                 if ( type = jQuery('#type-of-' + fileObj.id).val() )
                     jQuery('#' + type + '-counter').text(jQuery('#' + type + '-counter').text()-0+1);
@@ -211 +209 @@
         return;
 
-    item.html('<div class="error-div">'
-                + '<a class="dismiss" href="#">' + pluploadL10n.dismiss + '</a>'
-                + '<strong>' + pluploadL10n.error_uploading.replace('%s', jQuery.trim(filename)) + '</strong> '
-                + message
-                + '</div>').data('last-err', id);
-}
-
-function deleteSuccess(data, textStatus) {
+    item.html('<div class="error-div">' +
+                '<a class="dismiss" href="#">' + pluploadL10n.dismiss + '</a>' +
+                '<strong>' + pluploadL10n.error_uploading.replace('%s', jQuery.trim(filename)) + '</strong> ' +
+                message +
+                '</div>').data('last-err', id);
+}
+
+function deleteSuccess(data) {
+    var type, id, item;
     if ( data == '-1' )
         return itemAjaxError(this.id, 'You do not have permission. Has your session expired?');
@@ -225 +224 @@
         return itemAjaxError(this.id, 'Could not be deleted. Has it been deleted already?');
 
-    var id = this.id, item = jQuery('#media-item-' + id);
+    id = this.id;
+    item = jQuery('#media-item-' + id);
 
     // Decrement the counters.
@@ -253 +253 @@
 }
 
-function deleteError(X, textStatus, errorThrown) {
+function deleteError() {
     // TODO
 }
@@ -271 +271 @@
         setUserSetting('uploader', '1'); // 1 == html uploader
         jQuery('.media-upload-form').addClass('html-uploader');
-    }
-}
-
-function dndHelper(s) {
-    var d = document.getElementById('dnd-helper');
-
-    if ( s ) {
-        d.style.display = 'block';
-    } else {
-        d.style.display = 'none';
     }
 }
@@ -460 +450 @@
         });
 
-        uploader.bind('BeforeUpload', function(up, file) {
-            // something
-        });
+        // uploader.bind('BeforeUpload', function(up, file) {});
 
         uploader.bind('UploadFile', function(up, file) {
@@ -481 +469 @@
         });
 
-        uploader.bind('UploadComplete', function(up, files) {
+        uploader.bind('UploadComplete', function() {
             uploadComplete();
         });
-    }
-
-    if ( typeof(wpUploaderInit) == 'object' )
+    };
+
+    if ( typeof(wpUploaderInit) == 'object' ) {
         uploader_init();
+    }
 
 });