Changeset 26726 for trunk/src/wp-admin/includes/theme.php

Timestamp:

12/06/2013 04:10:25 PM (10 years ago)

Author:

nacin

Message:

No-JavaScript and no-Customizer support for the new Themes screen.

JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.

File:

• trunk/src/wp-admin/includes/theme.php (modified) (4 diffs)

trunk/src/wp-admin/includes/theme.php

@@ -379 +379 @@
  */
 function wp_prepare_themes_for_js( $themes = null ) {
-    $prepared_themes = array();
     $current_theme = get_stylesheet();
+
+    // Make sure the current theme is listed first.
+    $prepared_themes = array( $current_theme => array() );
 
     if ( null === $themes ) {
@@ -407 +409 @@
         $encoded_slug = urlencode( $slug );
 
-        $prepared_themes[] = array(
+        $prepared_themes[ $slug ] = array(
             'id'           => $slug,
             'name'         => $theme->display( 'Name' ),
@@ -423 +425 @@
                 'activate' => current_user_can( 'switch_themes' ) ? wp_nonce_url( admin_url( 'themes.php?action=activate&stylesheet=' . $encoded_slug ), 'switch-theme_' . $slug ) : null,
                 'customize'=> current_user_can( 'edit_theme_options' ) ? wp_customize_url( $slug ) : null,
+                'preview'   => add_query_arg( array(
+                    'preview'        => 1,
+                    'template'       => urlencode( $theme->get_template() ),
+                    'stylesheet'     => urlencode( $slug ),
+                    'preview_iframe' => true,
+                    'TB_iframe'      => true,
+                ), home_url( '/' ) ),
                 'delete'   => current_user_can( 'delete_themes' ) ? wp_nonce_url( admin_url( 'themes.php?action=delete&stylesheet=' . $encoded_slug ), 'delete-theme_' . $slug ) : null,
             ),
@@ -437 +446 @@
      * @param array $prepared_themes Array of themes.
      */
-    return apply_filters( 'wp_prepare_themes_for_js', $prepared_themes );
-}
+    $prepared_themes = apply_filters( 'wp_prepare_themes_for_js', $prepared_themes );
+    return array_values( $prepared_themes );
+}