Changeset 27905

Timestamp:

04/02/2014 01:04:30 PM (12 years ago)

Author:

dd32

Message:

Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-upgrader.php (modified) (6 diffs)
• wp-includes/update.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -1975 +1975 @@
                         return false;
 
+                $upgrader_item = $item;
                 switch ( $type ) {
                         case 'core':
@@ -1981 +1982 @@
                                 break;
                         case 'theme':
-                                $theme = wp_get_theme( $item );
+                                $upgrader_item = $item->theme;
+                                $theme = wp_get_theme( $upgrader_item );
                                 $item_name = $theme->Get( 'Name' );
                                 $skin->feedback( __( 'Updating theme: %s' ), $item_name );
                                 break;
                         case 'plugin':
-                                $plugin_data = get_plugin_data( $context . '/' . $item );
+                                $upgrader_item = $item->plugin;
+                                $plugin_data = get_plugin_data( $context . '/' . $upgrader_item );
                                 $item_name = $plugin_data['Name'];
                                 $skin->feedback( __( 'Updating plugin: %s' ), $item_name );
@@ -1998 +2001 @@
 
                 // Boom, This sites about to get a whole new splash of paint!
-                $upgrade_result = $upgrader->upgrade( $item, array(
+                $upgrade_result = $upgrader->upgrade( $upgrader_item, array(
                         'clear_update_cache' => false,
                         'pre_check_md5'      => false, /* always use partial builds if possible for core updates */
@@ -2072 +2075 @@
                 $plugin_updates = get_site_transient( 'update_plugins' );
                 if ( $plugin_updates && !empty( $plugin_updates->response ) ) {
-                        foreach ( array_keys( $plugin_updates->response ) as $plugin ) {
+                        foreach ( $plugin_updates->response as $plugin ) {
                                 $this->update( 'plugin', $plugin );
                         }
@@ -2083 +2086 @@
                 $theme_updates = get_site_transient( 'update_themes' );
                 if ( $theme_updates && !empty( $theme_updates->response ) ) {
-                        foreach ( array_keys( $theme_updates->response ) as $theme ) {
-                                $this->update( 'theme', $theme );
+                        foreach ( $theme_updates->response as $theme ) {
+                                $this->update( 'theme', (object) $theme );
                         }
                         // Force refresh of theme update information
@@ -2099 +2102 @@
                 // Clean up, and check for any pending translations
                 // (Core_Upgrader checks for core updates)
-                wp_update_themes();  // Check for Theme updates
-                wp_update_plugins(); // Check for Plugin updates
+                $theme_stats = array();
+                if ( isset( $this->update_results['theme'] ) ) {
+                        foreach ( $this->update_results['theme'] as $upgrade ) {
+                                $theme_stats[ $upgrade->item->theme ] = ( true === $upgrade->result );
+                        }
+                }
+                wp_update_themes( $theme_stats );  // Check for Theme updates
+
+                $plugin_stats = array();
+                if ( isset( $this->update_results['plugin'] ) ) {
+                        foreach ( $this->update_results['plugin'] as $upgrade ) {
+                                $plugin_stats[ $upgrade->item->plugin ] = ( true === $upgrade->result );
+                        }
+                }
+                wp_update_plugins( $plugin_stats ); // Check for Plugin updates
 
                 // Finally, Process any new translations

trunk/src/wp-includes/update.php

@@ -167 +167 @@
  * @uses $wp_version Used to notify the WordPress version.
  *
+ * @param array $extra_stats Extra statistics to report to the WordPress.org API.
  * @return mixed Returns null if update is unsupported. Returns false if check is too soon.
  */
-function wp_update_plugins() {
+function wp_update_plugins( $extra_stats = array() ) {
         include ABSPATH . WPINC . '/version.php'; // include an unmodified $wp_version
 
@@ -208 +209 @@
         $time_not_changed = isset( $current->last_checked ) && $timeout > ( time() - $current->last_checked );
 
-        if ( $time_not_changed ) {
+        if ( $time_not_changed && ! $extra_stats ) {
                 $plugin_changed = false;
                 foreach ( $plugins as $file => $p ) {
@@ -257 +258 @@
         );
 
+        if ( $plugin_update_stats ) {
+                $options['body']['update_stats'] = json_encode( $extra_stats );
+        }
+
         $url = $http_url = 'http://api.wordpress.org/plugins/update-check/1.1/';
         if ( $ssl = wp_http_supports( array( 'ssl' ) ) )
@@ -297 +302 @@
  * @uses $wp_version Used to notify the WordPress version.
  *
+ * @param array $extra_stats Extra statistics to report to the WordPress.org API.
  * @return mixed Returns null if update is unsupported. Returns false if check is too soon.
  */
-function wp_update_themes() {
+function wp_update_themes( $extra_stats = array() ) {
         include ABSPATH . WPINC . '/version.php'; // include an unmodified $wp_version
 
@@ -349 +355 @@
         $time_not_changed = isset( $last_update->last_checked ) && $timeout > ( time() - $last_update->last_checked );
 
-        if ( $time_not_changed ) {
+        if ( $time_not_changed && ! $extra_stats ) {
                 $theme_changed = false;
                 foreach ( $checked as $slug => $v ) {
@@ -395 +401 @@
                 'user-agent'    => 'WordPress/' . $wp_version . '; ' . get_bloginfo( 'url' )
         );
+
+        if ( $theme_update_stats ) {
+                $options['body']['update_stats'] = json_encode( $extra_stats );
+        }
 
         $url = $http_url = 'http://api.wordpress.org/themes/update-check/1.1/';