Changeset 28493 for trunk/src/wp-admin/includes/class-wp-themes-list-table.php

Timestamp:

05/19/2014 01:16:16 AM (10 years ago)

Author:

wonderboymusic

Message:

Add access modifiers to methods and members of list table classes:

• WP_List_Table is the base class that implements __get() and __call() for BC
• Adds unit tests to confirm that subclasses properly inherit magic methods
• Add modifiers to subclasses: WP_Links_List_Table, WP_Media_List_Table, WP_MS_Sites_List_Table, WP_MS_Themes_List_Table, WP_MS_Users_List_Table, WP_Plugin_Install_List_Table, WP_Plugins_List_Table, WP_Posts_List_Table, WP_Terms_List_Table, WP_Theme_Install_List_Table, WP_Themes_List_Table

See #27881, #22234.

File:

• trunk/src/wp-admin/includes/class-wp-themes-list-table.php (modified) (9 diffs)

trunk/src/wp-admin/includes/class-wp-themes-list-table.php

@@ -11 +11 @@
 
     protected $search_terms = array();
-    var $features = array();
-
-    function __construct( $args = array() ) {
+    public $features = array();
+
+    public function __construct( $args = array() ) {
         parent::__construct( array(
             'ajax' => true,
@@ -20 +20 @@
     }
 
-    function ajax_user_can() {
+    public function ajax_user_can() {
         // Do not check edit_theme_options here. AJAX calls for available themes require switch_themes.
         return current_user_can( 'switch_themes' );
     }
 
-    function prepare_items() {
+    public function prepare_items() {
         $themes = wp_get_themes( array( 'allowed' => true ) );
 
@@ -58 +58 @@
     }
 
-    function no_items() {
+    public function no_items() {
         if ( $this->search_terms || $this->features ) {
             _e( 'No items found.' );
@@ -86 +86 @@
     }
 
-    function tablenav( $which = 'top' ) {
+    public function tablenav( $which = 'top' ) {
         if ( $this->get_pagination_arg( 'total_pages' ) <= 1 )
             return;
@@ -98 +98 @@
     }
 
-    function display() {
+    public function display() {
         wp_nonce_field( "fetch-list-" . get_class( $this ), '_ajax_fetch_list_nonce' );
 ?>
@@ -111 +111 @@
     }
 
-    function get_columns() {
+    protected function get_columns() {
         return array();
     }
 
-    function display_rows_or_placeholder() {
+    protected function display_rows_or_placeholder() {
         if ( $this->has_items() ) {
             $this->display_rows();
@@ -125 +125 @@
     }
 
-    function display_rows() {
+    protected function display_rows() {
         $themes = $this->items;
 
@@ -209 +209 @@
     }
 
-    function search_theme( $theme ) {
+    public function search_theme( $theme ) {
         // Search the features
         foreach ( $this->features as $word ) {
@@ -250 +250 @@
      * @uses _pagination_args['total_pages']
      */
-     function _js_vars( $extra_args = array() ) {
+    private function _js_vars( $extra_args = array() ) {
         $search_string = isset( $_REQUEST['s'] ) ? esc_attr( wp_unslash( $_REQUEST['s'] ) ) : '';