Changeset 28737 for trunk/src/wp-includes/query.php

Timestamp:

06/11/2014 05:49:07 PM (10 years ago)

Author:

wonderboymusic

Message:

Don't use variable variables in WP_Query::get_posts().

See #27881.

File:

• trunk/src/wp-includes/query.php (modified) (2 diffs)

trunk/src/wp-includes/query.php

@@ -3083 +3083 @@
             $clauses = (array) apply_filters_ref_array( 'posts_clauses', array( compact( $pieces ), &$this ) );
 
-            foreach ( $pieces as $piece ) {
-                $$piece = isset( $clauses[ $piece ] ) ? $clauses[ $piece ] : '';
-            }
+            $where = isset( $clauses[ 'where' ] ) ? $clauses[ 'where' ] : '';
+            $groupby = isset( $clauses[ 'groupby' ] ) ? $clauses[ 'groupby' ] : '';
+            $join = isset( $clauses[ 'join' ] ) ? $clauses[ 'join' ] : '';
+            $orderby = isset( $clauses[ 'orderby' ] ) ? $clauses[ 'orderby' ] : '';
+            $distinct = isset( $clauses[ 'distinct' ] ) ? $clauses[ 'distinct' ] : '';
+            $fields = isset( $clauses[ 'fields' ] ) ? $clauses[ 'fields' ] : '';
+            $limits = isset( $clauses[ 'limits' ] ) ? $clauses[ 'limits' ] : '';
         }
 
@@ -3202 +3206 @@
              */
             $clauses = (array) apply_filters_ref_array( 'posts_clauses_request', array( compact( $pieces ), &$this ) );
-            foreach ( $pieces as $piece )
-                $$piece = isset( $clauses[ $piece ] ) ? $clauses[ $piece ] : '';
+
+            $where = isset( $clauses[ 'where' ] ) ? $clauses[ 'where' ] : '';
+            $groupby = isset( $clauses[ 'groupby' ] ) ? $clauses[ 'groupby' ] : '';
+            $join = isset( $clauses[ 'join' ] ) ? $clauses[ 'join' ] : '';
+            $orderby = isset( $clauses[ 'orderby' ] ) ? $clauses[ 'orderby' ] : '';
+            $distinct = isset( $clauses[ 'distinct' ] ) ? $clauses[ 'distinct' ] : '';
+            $fields = isset( $clauses[ 'fields' ] ) ? $clauses[ 'fields' ] : '';
+            $limits = isset( $clauses[ 'limits' ] ) ? $clauses[ 'limits' ] : '';
         }