Changeset 31188 for trunk/src/wp-includes/class-wp-customize-manager.php

Timestamp:

01/16/2015 01:05:52 AM (10 years ago)

Author:

wonderboymusic

Message:

In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning.

In PHP 5.3.0, is_a() is no longer deprecated, and will therefore no longer throw E_STRICT warnings.

To avoid warnings in PHP < 5.3.0, convert all is_a() calls to $var instanceof WP_Class calls.

instanceof does not throw any error if the variable being tested is not an object, it simply returns false.

Props markoheijnen, wonderboymusic.
Fixes #25672.

File:

• trunk/src/wp-includes/class-wp-customize-manager.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -696 +696 @@
      */
     public function add_setting( $id, $args = array() ) {
-        if ( is_a( $id, 'WP_Customize_Setting' ) )
+        if ( $id instanceof WP_Customize_Setting ) {
             $setting = $id;
-        else
+        } else {
             $setting = new WP_Customize_Setting( $this, $id, $args );
-
+        }
         $this->settings[ $setting->id ] = $setting;
     }
@@ -738 +738 @@
      */
     public function add_panel( $id, $args = array() ) {
-        if ( is_a( $id, 'WP_Customize_Panel' ) ) {
+        if ( $id instanceof WP_Customize_Panel ) {
             $panel = $id;
-        }
-        else {
+        } else {
             $panel = new WP_Customize_Panel( $this, $id, $args );
         }
@@ -784 +783 @@
      */
     public function add_section( $id, $args = array() ) {
-        if ( is_a( $id, 'WP_Customize_Section' ) )
+        if ( $id instanceof WP_Customize_Section ) {
             $section = $id;
-        else
+        } else {
             $section = new WP_Customize_Section( $this, $id, $args );
-
+        }
         $this->sections[ $section->id ] = $section;
     }
@@ -826 +825 @@
      */
     public function add_control( $id, $args = array() ) {
-        if ( is_a( $id, 'WP_Customize_Control' ) )
+        if ( $id instanceof WP_Customize_Control ) {
             $control = $id;
-        else
+        } else {
             $control = new WP_Customize_Control( $this, $id, $args );
-
+        }
         $this->controls[ $control->id ] = $control;
     }