Make WordPress Core


Ignore:
Timestamp:
01/16/2015 10:50:20 PM (11 years ago)
Author:
wonderboymusic
Message:

Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:

  • In WP_Importer->is_user_over_quota(), the default value for the first argument for upload_is_user_over_quota() is true. Don't bother passing 1.
  • When calling submit_button() with no $name, pass empty string instead of false.
  • The default value for the 2nd argument to get_edit_post_link() is 'display'. Because PHP is PHP, passing true is the same as passing 'display' or nothing. Don't bother passing true.
  • In WP_User_Meta_Session_Tokens::drop_sessions(), pass 0 instead of false to delete_metadata() as the value for $object_id, which expects an int.

See #30799.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-importer.php

    r31125 r31220  
    210210    public function is_user_over_quota() {
    211211        if ( function_exists( 'upload_is_user_over_quota' ) ) {
    212             if ( upload_is_user_over_quota( 1 ) ) {
     212            if ( upload_is_user_over_quota() ) {
    213213                echo "Sorry, you have used your upload quota.\n";
    214214                return true;
Note: See TracChangeset for help on using the changeset viewer.