Changeset 31307

Timestamp:

01/30/2015 07:17:51 PM (10 years ago)

Author:

boonebgorges

Message:

Introduce 'show_in_quick_edit' parameter for register_taxonomy().

Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-posts-list-table.php (modified) (1 diff)
• src/wp-includes/taxonomy.php (modified) (4 diffs)
• tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -945 +945 @@
         $flat_taxonomies = array();
         foreach ( $taxonomy_names as $taxonomy_name ) {
+
+            /**
+             * Filters whether the current taxonomy should be shown in the Quick Edit panel.
+             *
+             * @since 4.2.0
+             *
+             * @param bool   $show          Whether to show the current taxonomy in Quick Edit.
+             *                              Default: true.
+             * @param string $taxonomy_name Taxonomy name.
+             * @param string $post_type     Post type of current Quick Edit post.
+             */
+            if ( ! apply_filters( 'quick_edit_show_taxonomy', true, $taxonomy_name, $screen->post_type ) ) {
+                continue;
+            }
+
             $taxonomy = get_taxonomy( $taxonomy_name );
 
-            if ( !$taxonomy->show_ui )
+            if ( ! $taxonomy->show_in_quick_edit ) {
                 continue;
+            }
 
             if ( $taxonomy->hierarchical )

trunk/src/wp-includes/taxonomy.php

@@ -283 +283 @@
  * - show_tagcloud - Whether to list the taxonomy in the Tag Cloud Widget.
  *     * If not set, the default is inherited from show_ui.
+ * - show_in_quick_edit - Whether to show the taxonomy in the quick/bulk edit panel.
+ *     * It not set, the default is inherited from show_ui.
  * - show_admin_column - Whether to display a column for the taxonomy on its post type listing screens.
  *     * Defaults to false.
@@ -309 +311 @@
  *
  * @since 2.3.0
+ * @since 4.2.0 Introduced 'show_in_quick_edit' parameter.
  * @uses $wp_taxonomies Inserts new taxonomy object into the list
  * @uses $wp Adds query vars
@@ -332 +335 @@
         'show_in_nav_menus'     => null,
         'show_tagcloud'         => null,
+        'show_in_quick_edit'    => null,
         'show_admin_column'     => false,
         'meta_box_cb'           => null,
@@ -389 +393 @@
     if ( null === $args['show_tagcloud'] )
         $args['show_tagcloud'] = $args['show_ui'];
+
+    // If not set, default to the setting for show_ui.
+    if ( null === $args['show_in_quick_edit'] ) {
+        $args['show_in_quick_edit'] = $args['show_ui'];
+    }
 
     $default_caps = array(

trunk/tests/phpunit/tests/taxonomy.php

@@ -164 +164 @@
 
     /**
+     * @ticket 26948
+     */
+    public function test_register_taxonomy_show_in_quick_edit_should_default_to_value_of_show_ui() {
+        register_taxonomy( 'wptests_tax_1', 'post', array(
+            'show_ui' => true,
+        ) );
+
+        register_taxonomy( 'wptests_tax_2', 'post', array(
+            'show_ui' => false,
+        ) );
+
+        $tax_1 = get_taxonomy( 'wptests_tax_1' );
+        $this->assertTrue( $tax_1->show_in_quick_edit );
+
+        $tax_2 = get_taxonomy( 'wptests_tax_2' );
+        $this->assertFalse( $tax_2->show_in_quick_edit );
+    }
+
+    /**
      * @ticket 11058
      */