Changeset 32545 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

05/22/2015 05:46:47 AM (9 years ago)

Author:

wonderboymusic

Message:

When calling unset(), it is unnecessary to immediately precede it with a call to isset().

See #32444.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (1 diff)

trunk/src/wp-admin/includes/nav-menu.php

@@ -1281 +1281 @@
             $menu_item_db_id = wp_update_nav_menu_item( $nav_menu_selected_id, ( $_POST['menu-item-db-id'][$_key] != $_key ? 0 : $_key ), $args );
 
-            if ( is_wp_error( $menu_item_db_id ) )
+            if ( is_wp_error( $menu_item_db_id ) ) {
                 $messages[] = '<div id="message" class="error"><p>' . $menu_item_db_id->get_error_message() . '</p></div>';
-            elseif ( isset( $menu_items[$menu_item_db_id] ) )
-                unset( $menu_items[$menu_item_db_id] );
+            } else {
+                unset( $menu_items[ $menu_item_db_id ] );
+            }
         }
     }