Changeset 32720

Timestamp:

06/10/2015 09:08:10 AM (9 years ago)

Author:

obenland

Message:

More semantic markup for the post formats metabox.

Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-press-this.php (modified) (1 diff)
• meta-boxes.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-press-this.php

@@ -791 +791 @@
                 ?>
                 <div id="post-formats-select">
-                <fieldset><legend class="screen-reader-text"><?php _e( 'Post formats' ); ?></legend>
+                <fieldset><legend class="screen-reader-text"><?php _e( 'Post Formats' ); ?></legend>
                     <input type="radio" name="post_format" class="post-format" id="post-format-0" value="0" <?php checked( $post_format, '0' ); ?> />
                     <label for="post-format-0" class="post-format-icon post-format-standard"><?php echo get_post_format_string( 'standard' ); ?></label>

trunk/src/wp-admin/includes/meta-boxes.php

@@ -371 +371 @@
     ?>
     <div id="post-formats-select">
-        <input type="radio" name="post_format" class="post-format" id="post-format-0" value="0" <?php checked( $post_format, '0' ); ?> /> <label for="post-format-0" class="post-format-icon post-format-standard"><?php echo get_post_format_string( 'standard' ); ?></label>
-        <?php foreach ( $post_formats[0] as $format ) : ?>
-        <br /><input type="radio" name="post_format" class="post-format" id="post-format-<?php echo esc_attr( $format ); ?>" value="<?php echo esc_attr( $format ); ?>" <?php checked( $post_format, $format ); ?> /> <label for="post-format-<?php echo esc_attr( $format ); ?>" class="post-format-icon post-format-<?php echo esc_attr( $format ); ?>"><?php echo esc_html( get_post_format_string( $format ) ); ?></label>
-        <?php endforeach; ?><br />
+        <fieldset>
+            <legend class="screen-reader-text"><?php _e( 'Post Formats' ); ?></legend>
+            <input type="radio" name="post_format" class="post-format" id="post-format-0" value="0" <?php checked( $post_format, '0' ); ?> /> <label for="post-format-0" class="post-format-icon post-format-standard"><?php echo get_post_format_string( 'standard' ); ?></label>
+            <?php foreach ( $post_formats[0] as $format ) : ?>
+            <br /><input type="radio" name="post_format" class="post-format" id="post-format-<?php echo esc_attr( $format ); ?>" value="<?php echo esc_attr( $format ); ?>" <?php checked( $post_format, $format ); ?> /> <label for="post-format-<?php echo esc_attr( $format ); ?>" class="post-format-icon post-format-<?php echo esc_attr( $format ); ?>"><?php echo esc_html( get_post_format_string( $format ) ); ?></label>
+            <?php endforeach; ?>
+        </fieldset>
     </div>
     <?php endif; endif;