WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/deprecated.php

    r32800 r32990  
    471471
    472472    /**
    473      * PHP4 Constructor - Sets up the object properties.
     473     * PHP5 Constructor - Sets up the object properties.
    474474     *
    475475     * @since 2.1.0
     
    480480     * @return WP_User_Search
    481481     */
    482     function WP_User_Search ($search_term = '', $page = '', $role = '') {
     482    function __construct( $search_term = '', $page = '', $role = '' ) {
    483483        _deprecated_function( __FUNCTION__, '3.1', 'WP_User_Query' );
    484484
     
    491491        $this->query();
    492492        $this->do_paging();
     493    }
     494
     495    /**
     496     * PHP4 Constructor - Sets up the object properties.
     497     *
     498     * @since 2.1.0
     499     *
     500     * @param string $search_term Search terms string.
     501     * @param int $page Optional. Page ID.
     502     * @param string $role Role name.
     503     * @return WP_User_Search
     504     */
     505    public function WP_User_Search( $search_term = '', $page = '', $role = '' ) {
     506        self::__construct( $search_term, $page, $role );
    493507    }
    494508
Note: See TracChangeset for help on using the changeset viewer.