Changeset 32990 for trunk/src/wp-admin/includes/deprecated.php

Timestamp:

06/28/2015 03:26:41 PM (10 years ago)

Author:

jorbin

Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: ​https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:

• trunk/src/wp-admin/includes/deprecated.php (modified) (3 diffs)

trunk/src/wp-admin/includes/deprecated.php

@@ -471 +471 @@
 
     /**
-     * PHP4 Constructor - Sets up the object properties.
+     * PHP5 Constructor - Sets up the object properties.
      *
      * @since 2.1.0
@@ -480 +480 @@
      * @return WP_User_Search
      */
-    function WP_User_Search ($search_term = '', $page = '', $role = '') {
+    function __construct( $search_term = '', $page = '', $role = '' ) {
         _deprecated_function( __FUNCTION__, '3.1', 'WP_User_Query' );
 
@@ -491 +491 @@
         $this->query();
         $this->do_paging();
+    }
+
+    /**
+     * PHP4 Constructor - Sets up the object properties.
+     *
+     * @since 2.1.0
+     *
+     * @param string $search_term Search terms string.
+     * @param int $page Optional. Page ID.
+     * @param string $role Role name.
+     * @return WP_User_Search
+     */
+    public function WP_User_Search( $search_term = '', $page = '', $role = '' ) {
+        self::__construct( $search_term, $page, $role );
     }